Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6839] fix api1_and_js tests - part 2 #10903

Conversation

Vlad0n20
Copy link

@Vlad0n20 Vlad0n20 commented Jan 9, 2025

Purpose

fix api1_and_js tests

Changes

Update some functionality for versioned guids

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-6839?atlOrigin=eyJpIjoiZTA3OTYxOTBlMDU3NGNjNmE2Mjc5ZTc1ODgwMzIxNjYiLCJwIjoiaiJ9

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put this ticket/PR on hold since I think we have some problem with API filters. I will take a initial look at https://openscience.atlassian.net/browse/ENG-6878 first.

api/base/filters.py Show resolved Hide resolved
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes in this PR are no long relevant since other PRs have fixed 8 of 10 errors.

I am llosing this PR and fixed the rest two.

=========================== short test summary info ============================
FAILED api_tests/providers/preprints/views/test_preprint_provider_request_list.py::TestPreprintProviderWithdrawalRequstList::test_list - assert 0 == 1
 +  where 0 = len([])
FAILED api_tests/users/views/test_user_claim.py::TestClaimUser::test_claim_unauth_success_with_preprint_id - webtest.app.AppError: Bad response: 404 Not Found (not 200 OK or 3xx redirect for http://localhost/v2/users/dzyvk/claim/)
{"errors":[{"detail":"Unable to find specified record."}],"meta":{"version":"2.0"}}
=== 2 failed, 2715 passed, 41 skipped, 19717 warnings in 1396.18s (0:23:16) ====

api_tests/users/views/test_user_claim.py Show resolved Hide resolved
@cslzchen
Copy link
Collaborator

@cslzchen cslzchen closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants