[Bugs] Fix migrations and admin institutional permissions problems #10914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
fix-migration-for-iac
branch
from
dac0fde to
1fbb50d
Compare
Johnetordoff
force-pushed
the
fix-migration-for-iac
branch
from
1fbb50d to
f1904a9
Compare
cslzchen
reviewed
Jan 13, 2025
| @@ -255,8 +255,9 @@ def form_valid(self, form): | |||
| if not osf_user: | |||
| raise Http404(f'OSF user with id "{user_id}" not found. Please double check.') | |||
|
|
|||
| group = Group.objects.filter(name__startswith=f'institution_{target_institution._id}').first() | |||
| osf_user.add_or_update_affiliated_institution(target_institution) | |||
There was a problem hiding this comment.
Per my discussion with @Johnetordoff , we should not add affiliation to user outside of SSO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes two bugs:
ngo.db.utils.ProgrammingError: column "institutional_request_access_enabled" of relation "osf_institution" already existsChanges
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket