[ENG-6882]fixed double mail sending #10919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn`t add new test cases as existing ones covers new implementation |
Johnetordoff
force-pushed
the
feature/double_email_fix
branch
from
3e710a4 to
3c93931
Compare
|
@bodintsov I'm sorry I accidentally pushed to your branch while I testing some code. I revert now. |
brianjgeiger
requested changes
Jan 15, 2025
admin/base/settings/defaults.py
Outdated
Comment on lines
44
to
45
| 'localhost', | ||
| '127.0.0.1' |
There was a problem hiding this comment.
These shouldn't be in defaults. This should only be in your local settings overrides.
There was a problem hiding this comment.
Yes, it`s my mistake, removed
osf/features.yaml
Outdated
| @@ -192,6 +192,7 @@ flags: | |||
| - flag_name: INSTITUTIONAL_DASHBOARD_2024 | |||
| name: institutional_dashboard_2024 | |||
| note: whether to surface older or updated (in 2024) institutional metrics | |||
| everyone: false | |||
There was a problem hiding this comment.
Is this supposed to be part of this PR?
There was a problem hiding this comment.
No, it`s just my mistake, removed
bodintsov
force-pushed
the
feature/double_email_fix
branch
from
3c93931 to
bb243a1
Compare
brianjgeiger
approved these changes
Jan 15, 2025
Johnetordoff
merged commit e5cc7fe
into
CenterForOpenScience:feature/institutional_access
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix sending 2 emails instead of 1 when using institutional access project requests
Changes
TBD
QA Notes
TBD
Documentation
TBD
Side Effects
TBD
Ticket
(https://openscience.atlassian.net/browse/ENG-6882)