Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soufianej k3s playbook #292

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Soufianej k3s playbook #292

merged 3 commits into from
Jun 25, 2024

Conversation

JOUNAIDSoufiane
Copy link
Contributor

  • Removed the ansible_managed flag from k3s template files
  • Added a pip task to install the kubernetes python library

msherman64
msherman64 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming nits are double-checked

roles/k3s/tasks/config-k3s-service.yml Outdated Show resolved Hide resolved
codyhammock
codyhammock approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@codyhammock codyhammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JOUNAIDSoufiane JOUNAIDSoufiane merged commit e56d942 into stable/xena Jun 25, 2024
1 check passed
@msherman64 msherman64 deleted the soufianej-k3s-playbook branch October 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherman64 msherman64 msherman64 approved these changes

@codyhammock codyhammock codyhammock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JOUNAIDSoufiane @codyhammock @msherman64