Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't force 96 dpi #5802

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 7, 2025

Setting AA_Use96Dpi would fix fonts to a specific pixel/point size (usage in Qt). We want the fonts to scale and use the scale provided by the OS. I only tested this on Windows.

Fixes #5411.

Tests

The following tests should be done for each platform and configuration:

  1. Dragging across screens of equal High-DPI scaling (if >1 screens) - are there issues or window size changes?
  2. Saving on each screen - does the window appear at the same size when launched again?
  3. Are the fonts reasonably sized compared to other apps?
  4. Zooming in and out - does this look reasonable? Does saving work?

Platforms and Setups

  • Windows
    • Single-monitor
      • 100% scale
      • >100% scale
    • Multi-monitor
      • all 100% scale
      • all >100% scale (but equal)
      • all >100% scale (different)
      • some 100%, some >100% scale
      • At least two setups from the linked issue (not sure what the exact cause is, probably the monitor)
  • macOS
    • 100% scale
    • >100% scale (on a laptop)
  • Linux
    • x11
      • 100% scale
      • >100% scale
    • Wayland
      • 100% scale
      • >100% scale

@pajlada
Copy link
Member

pajlada commented Jan 7, 2025

Good catch!

Linux (Wayland w/ sway), 100% monitor

Text renders the same, icons render slightly different but only better from what I can tell

Linux (Wayland w/ sway), 150% monitor

Text is aliased differently, but I'm not 100% sure if this is due to screenshots scaling weirdly on sway. When I look at the monitor itself, everything looks very good still. Nothing has changed significantly in size.

macOS 200% monitor

Tab text size, Tab size, and chat text size are all smaller with this change. It's more in line with other texts (text input & chat header). Text still looks sharp. Overall I think this change is fine on macOS, but I could do more thorough testing in settings & menus to see if anything changes there.

macOS 100% monitor

Not tested yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab widths do not fit properly to text at 125% scale on Windows
2 participants