Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound button added #539

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Sound button added #539

merged 3 commits into from
Jul 21, 2024

Conversation

VijaySamant4368
Copy link
Contributor

PR Description 📜

Added sound button. The sound button now toggles the stroke and fill sound, while the music button toggles the bg music.
Fixes #536

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.
## Add your screenshots(Optional) 📸

image


Thank you soo much for contributing to our repository 💗

@VijaySamant4368
Copy link
Contributor Author

@ayush-t02 please check and merge this pr.

@ayush-t02
Copy link
Collaborator

resolve conflicts

@VijaySamant4368
Copy link
Contributor Author

@ayush-t02 resolved

@ayush-t02 ayush-t02 merged commit e972f29 into ChromeGaming:main Jul 21, 2024
@VijaySamant4368 VijaySamant4368 deleted the sound branch July 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VijaySamant4368 VijaySamant4368

Labels
gssoc level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Sound Off button
2 participants
@VijaySamant4368 @ayush-t02