Minor active directory join point updates

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - Fix import operation of nested resources (e.g. `ise_network_access_authentication_rule`)
 - Fix name-based queries for `device_admin` and `network_access` data sources
+- Add `ise_active_directory_join_point` resource and data source
 
 ## 0.1.10
 

docs/data-sources/active_directory_join_point.md

@@ -27,21 +27,21 @@ data "ise_active_directory_join_point" "example" {
 
 ### Read-Only
 
-- `ad_scopes_names` (String) String that contains the names of the scopes that the active directory belongs to. Names are separated by comm
+- `ad_scopes_names` (String) String that contains the names of the scopes that the active directory belongs to. Names are separated by comma.
 - `aging_time` (Number) Aging Time
-- `attributes` (Attributes List) List of AD Attributes (see [below for nested schema](#nestedatt--attributes))
+- `attributes` (Attributes List) List of AD attributes (see [below for nested schema](#nestedatt--attributes))
 - `auth_protection_type` (String) Enable prevent AD account lockout for WIRELESS/WIRED/BOTH
 - `country` (String) User info attribute
 - `department` (String) User info attribute
-- `description` (String) Join point Description
+- `description` (String) Join point description
 - `domain` (String) AD domain associated with the join point
 - `email` (String) User info attribute
 - `enable_callback_for_dialin_client` (Boolean) Enable Callback For Dial In Client
 - `enable_dialin_permission_check` (Boolean) Enable Dial In Permission Check
 - `enable_domain_allowed_list` (Boolean)
 - `enable_failed_auth_protection` (Boolean) Enable prevent AD account lockout due to too many bad password attempts
 - `enable_machine_access` (Boolean) Enable Machine Access
-- `enable_machine_auth` (Boolean) Enable Machin Authentication
+- `enable_machine_auth` (Boolean) Enable Machine Authentication
 - `enable_pass_change` (Boolean) Enable Password Change
 - `enable_rewrites` (Boolean) Enable Rewrites
 - `failed_auth_threshold` (Number) Number of bad password attempts
@@ -66,7 +66,7 @@ data "ise_active_directory_join_point" "example" {
 
 Read-Only:
 
-- `default_value` (String) Required for each attribute in the attribute list. Can contain an empty string
+- `default_value` (String) Required for each attribute in the attribute list. Can contain an empty string.
 - `internal_name` (String) Required for each attribute in the attribute list
 - `name` (String) Required for each attribute in the attribute list with no duplication between attributes
 - `type` (String) Required for each group in the group list

docs/guides/changelog.md

@@ -11,6 +11,7 @@ description: |-
 
 - Fix import operation of nested resources (e.g. `ise_network_access_authentication_rule`)
 - Fix name-based queries for `device_admin` and `network_access` data sources
+- Add `ise_active_directory_join_point` resource and data source
 
 ## 0.1.10
 

docs/resources/active_directory_join_point.md

@@ -79,16 +79,16 @@ resource "ise_active_directory_join_point" "example" {
 
 ### Optional
 
-- `ad_scopes_names` (String) String that contains the names of the scopes that the active directory belongs to. Names are separated by comm
+- `ad_scopes_names` (String) String that contains the names of the scopes that the active directory belongs to. Names are separated by comma.
   - Default value: `Default_Scope`
 - `aging_time` (Number) Aging Time
   - Default value: `5`
-- `attributes` (Attributes List) List of AD Attributes (see [below for nested schema](#nestedatt--attributes))
+- `attributes` (Attributes List) List of AD attributes (see [below for nested schema](#nestedatt--attributes))
 - `auth_protection_type` (String) Enable prevent AD account lockout for WIRELESS/WIRED/BOTH
   - Choices: `WIRELESS`, `WIRED`, `BOTH`
 - `country` (String) User info attribute
 - `department` (String) User info attribute
-- `description` (String) Join point Description
+- `description` (String) Join point description
 - `email` (String) User info attribute
 - `enable_callback_for_dialin_client` (Boolean) Enable Callback For Dial In Client
   - Default value: `false`
@@ -99,7 +99,7 @@ resource "ise_active_directory_join_point" "example" {
   - Default value: `false`
 - `enable_machine_access` (Boolean) Enable Machine Access
   - Default value: `true`
-- `enable_machine_auth` (Boolean) Enable Machin Authentication
+- `enable_machine_auth` (Boolean) Enable Machine Authentication
   - Default value: `true`
 - `enable_pass_change` (Boolean) Enable Password Change
   - Default value: `true`
@@ -135,7 +135,7 @@ resource "ise_active_directory_join_point" "example" {
 
 Required:
 
-- `default_value` (String) Required for each attribute in the attribute list. Can contain an empty string
+- `default_value` (String) Required for each attribute in the attribute list. Can contain an empty string.
 - `internal_name` (String) Required for each attribute in the attribute list
 - `name` (String) Required for each attribute in the attribute list with no duplication between attributes
 - `type` (String) Required for each group in the group list

gen/definitions/active_directory_join_point.yaml

@@ -3,6 +3,7 @@ name: Active Directory Join Point
 rest_endpoint: /ers/config/activedirectory
 doc_category: Identity Management
 skip_minimum_test: true
+test_tags: [AD]
 attributes:
   - model_name: name
     data_path: [ERSActiveDirectory]
@@ -14,7 +15,7 @@ attributes:
     data_path: [ERSActiveDirectory]
     type: String
     requires_replace: true
-    description: Join point Description
+    description: Join point description
     example: My AD join point
   - model_name: domain
     data_path: [ERSActiveDirectory]
@@ -27,7 +28,7 @@ attributes:
     data_path: [ERSActiveDirectory]
     type: String
     requires_replace: true
-    description: String that contains the names of the scopes that the active directory belongs to. Names are separated by comm
+    description: String that contains the names of the scopes that the active directory belongs to. Names are separated by comma.
     default_value: Default_Scope
     example: Default_Scope
   - model_name: enableDomainAllowedList
@@ -38,7 +39,7 @@ attributes:
     example: true
   - model_name: groups
     description: List of AD Groups
-    data_path: [ERSActiveDirectory,adgroups] 
+    data_path: [ERSActiveDirectory, adgroups] 
     type: List
     attributes:
       - model_name: name
@@ -60,9 +61,9 @@ attributes:
         requires_replace: true
         example: GLOBAL
   - model_name: attributes
-    data_path: [ERSActiveDirectory,adAttributes] 
+    data_path: [ERSActiveDirectory, adAttributes] 
     type: List
-    description: List of AD Attributes
+    description: List of AD attributes
     attributes:
       - model_name: name
         type: String
@@ -87,10 +88,10 @@ attributes:
         type: String
         requires_replace: true
         mandatory: true
-        description: Required for each attribute in the attribute list. Can contain an empty string
+        description: Required for each attribute in the attribute list. Can contain an empty string.
         example: default_string
   - model_name: rewriteRules
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: List
     description: List of Rewrite rules
     attributes:
@@ -113,164 +114,164 @@ attributes:
         description: Required for each rule in the list
         example: rewrite_result
   - model_name: enableRewrites
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: false
     description: Enable Rewrites
     example: false
   - model_name: enablePassChange
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: true
     description: Enable Password Change
     example: true
   - model_name: enableMachineAuth
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: true
-    description: Enable Machin Authentication
+    description: Enable Machine Authentication
     example: true
   - model_name: enableMachineAccess
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: true
     description: Enable Machine Access
     example: true
   - model_name: enableDialinPermissionCheck
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: false
     description: Enable Dial In Permission Check
     example: false
   - model_name: plaintextAuth
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: false
     description: Plain Text Authentication
     example: false
   - model_name: agingTime
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Int64
     requires_replace: true
     default_value: 5
     description: Aging Time
     example: 5
   - model_name: enableCallbackForDialinClient
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     default_value: false
     description: Enable Callback For Dial In Client
     example: false
   - model_name: identityNotInAdBehaviour
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     enum_values: [REJECT, SEARCH_JOINED_FOREST, SEARCH_ALL]
     description: Identity Not In AD Behaviour
     example: SEARCH_JOINED_FOREST
   - model_name: unreachableDomainsBehaviour
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     enum_values: [PROCEED, DROP]
     description: Unreachable Domains Behaviour
     example: PROCEED
   - model_name: schema
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     enum_values: [ACTIVE_DIRECTORY, CUSTOM]
     description: Schema
     example: ACTIVE_DIRECTORY
   - model_name: firstName
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: givenName
   - model_name: department
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: department
   - model_name: lastName
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: sn
   - model_name: organizationalUnit
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: company
   - model_name: jobTitle
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: title
   - model_name: locality
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: l
   - model_name: email
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: mail
   - model_name: stateOrProvince
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: st
   - model_name: telephone
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: telephoneNumber
   - model_name: country
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: co
   - model_name: streetAddress
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     description: User info attribute
     example: streetAddress
   - model_name: enableFailedAuthProtection
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Bool
     requires_replace: true
     description: Enable prevent AD account lockout due to too many bad password attempts
     example: false
     default_value: false
   - model_name: failedAuthThreshold
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: Int64
     requires_replace: true
     default_value: 5
     description: Number of bad password attempts
     example: 5
   - model_name: authProtectionType
-    data_path: [ERSActiveDirectory,advancedSettings]
+    data_path: [ERSActiveDirectory, advancedSettings]
     type: String
     requires_replace: true
     enum_values: [WIRELESS, WIRED, BOTH]