-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access type for keyless entry #1485
Conversation
ec2a815
to
3a24b5b
Compare
3a24b5b
to
dc8cbc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that should be clarified is the logic on how the logic between keyless_entry_start_date
, keyless_entry_end_date
and method_of_entry
works.
If the method is set to MethodOfEntry.KEYLESS
and start/end date is set, what is the method before/after the date?
I would assume it would always just be KEYLESS
, but the ticket mentions:
(Tämän aikavälin ulkopuolella kulku katsotaan kuitenkin avoimeksi.)
Having the start/end dates set when the method is KEYLESS
would be a bit confusing and open to open for interpretation. I'm thinking if we should the block setting start/end dates if the method is set to KEYLESS
?
The ticket also mentions:
(Varausten tilastoihin tarvitaan kuitenkin boolean-tieto, oliko kyseessä pääsykoodin vaatinut varaus.)
Which is not implemented here. But it is also not in the acceptance criteria, so I would assume that this is coming later at some point?
In HAUKI there are some states (HaukiResourceState
) that mention a key, do those relate to WITH_KEY
/KEYLESS
in any way? 🤔
@ranta This can be implemented when keyless entry is integrated to the reservations flow. |
@ranta No relation. |
dc8cbc6
to
1c6a73d
Compare
e7cce4a
to
5cc707a
Compare
cf27c2e
to
a9c34aa
Compare
fcb437b
to
e798636
Compare
Quality Gate passedIssues Measures |
/ff |
🛠️ Changelog
access_type
(="kulkuoikeus") to the reservation unit model for keyless entryaccess_type_start_date
andaccess_type_end_date
to the reservation unit model for enabling onboarding to or offboarding from different access typesaccess_type
to the admin panel and check the reservation unit from Pindora if changed to "ACCESS_CODE"🧪 Test plan
🚧 Dependencies
🎫 Tickets