Merge pull request #3 from Clarilab/fix/map-constant-keys

fix: use Language as key type in map

countries.go

@@ -54,8 +54,8 @@ func findCountryByAlpha3(query string) (*Mapping, error) {
 
 func findCountryByNameOrNationality(query string) (*Mapping, error) {
 	for i := range mappings {
-		if isCountryNameOrNationality(mappings[i].Translations[string(EN)], query) ||
-			isCountryNameOrNationality(mappings[i].Translations[string(DE)], query) {
+		if isCountryNameOrNationality(mappings[i].Translations[EN], query) ||
+			isCountryNameOrNationality(mappings[i].Translations[DE], query) {
 			return &mappings[i], nil
 		}
 	}
@@ -96,7 +96,7 @@ func CountryName(query string) string {
 		return ""
 	}
 
-	return country.Translations[string(EN)].Common
+	return country.Translations[EN].Common
 }
 
 // CountryTranslation looks up any matching occurrence for the query and returns the country translation.
@@ -106,7 +106,7 @@ func CountryTranslation(query string, lang Language) (*Translation, error) {
 		return nil, ErrCountryNotFound
 	}
 
-	translation, ok := country.Translations[string(lang)]
+	translation, ok := country.Translations[lang]
 	if !ok {
 		return nil, ErrTranslationNotFound
 	}

countries_test.go

@@ -11,7 +11,7 @@ func TestAlpha2(t *testing.T) {
 		country := countries.AllMappings()[i]
 
 		t.Run("find by country name", func(t *testing.T) {
-			alpha2 := countries.Alpha2(country.Translations[string(countries.EN)].Common)
+			alpha2 := countries.Alpha2(country.Translations[countries.EN].Common)
 			if country.Alpha2 != alpha2 {
 				t.Errorf("expected: %s, got: %s", country.Alpha2, alpha2)
 			}