Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed vendor.set(JvmVendorSpec.ADOPTIUM) #2104

Closed
wants to merge 1 commit into from
Closed

removed vendor.set(JvmVendorSpec.ADOPTIUM) #2104

wants to merge 1 commit into from

Conversation

siom79
Copy link
Contributor

@siom79 siom79 commented Mar 11, 2023

Fixes issue #2103.

There is no need to fix down the JVM vendor spec.

@siom79
Copy link
Contributor Author

siom79 commented Mar 12, 2023

The root cause seems to be this issue: gradle/gradle#19295
Closing this PR.

@siom79 siom79 closed this Mar 12, 2023
@SupremeMortal
Copy link
Member

Did removing the vendor fix the issue for you? As far as I'm aware, Adoptium doesn't ship an ARM binary for JDK 8 which would explain the issues you are experiencing.

@SupremeMortal
Copy link
Member

Switched over to Azul which has a much wider variety of supported CPU architectures 7b9a9ec

@siom79
Copy link
Contributor Author

siom79 commented Mar 12, 2023

Why do you want to lock down the JVM vendor? If there is not specific reason, just let everybody chose their own.

@IWareQ
Copy link

IWareQ commented Mar 12, 2023

Why do you want to lock down the JVM vendor? If there is not specific reason, just let everybody chose their own.

I agree with siom79, Nukkit is compiled by what the user has installed

@SupremeMortal
Copy link
Member

SupremeMortal commented Mar 12, 2023

Yes, the vendor can be removed however, our usage of the toolchain in Gradle means we can create reproducible builds with the same version of the JDK instead of being compiled against whatever the user has installed. It makes it easier for the end user to compile Nukkit without having the correct JDK.

This obviously had the unintended side-effect of breaking some users' builds on unsupported Temurin JDK architectures initially, but it has now been fixed. Without the vendor set, it will now use any correctly versioned JDKs installed by the user, or revert back to downloading the reference implementation OpenJDK to compile against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants