Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map thumbnail preview to multiplayer game lobby map list hover #637

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

11EJDE11
Copy link
Contributor

Still a bit of a draft but figured I'd submit now and get some initial feedback.

  • Do others want this, or just me?
  • Would this be better behind a toggle? For example, right click the map list and choose "Show previews"
  • Add it to skirmish map list box too?
  • Is there other information that should show?

Like the other recent PR from Grant that adds map previews, this preview is only shown for maps with the texture file. The reason for this was lag on large map previews. I've never dealt with threading before - do you think it's possible to load the preview in another thread in order to have all previews working rather than those with just the texture file?

Here it is currently:
XNAMapPreviewGameLobby

@pzhlkj6612
Copy link
Contributor

Looks cool!

  • Do others want this, or just me?

I want this as a player who is always lost in the map list.


It would be nice if we highlighted the map with a dark color (configurable) where the mouse is hovering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants