Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating search keys in General Settings #1470

Merged

Conversation

luah5
Copy link
Member

@luah5 luah5 commented Nov 1, 2023

Description

Added the search keys required for CE's settings to be fully searchable.

Search Keys added:

  • Show Path Bar: N/A
  • Dim editors without focus: N/A
  • Issue Navigator Detail: Might want to dim the text in a way that shows that this setting is disabled
  • Show “Open With CodeEdit“ option in Finder: N/A
  • 'codeedit' Shell command: same as Issue Navigator Detail
  • Dialog Warnings: same as 'codeedit' Shell comand and Issue Navigator Detail
  • Check for app updates: N/A
  • Automatically check for app updates: N/A
  • Include pre-release versions: N/A

Related Issues

No issue related but might be useful to have an issue that opens and closes when a new setting is being added. That way CE's settings remain fully searchable.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

I won't provide any screenshots as this PR is quite self-explanatory, but if anybody needs it I'll upload one.

@luah5
Copy link
Member Author

luah5 commented Nov 18, 2023

Is this PR ready to merge?

@austincondiff
Copy link
Collaborator

Looks like it. We will get this reviewed

@thecoolwinter thecoolwinter merged commit 72833bc into CodeEditApp:main Nov 18, 2023
2 checks passed
Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants