Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small improvement for git fetching.
Previously, a timer was used to fetch the repo when the source control sidebar pane is active. This timer launches a new task, but doesn't keep track of it. When a fetch takes more than 10 seconds, the timer will start fetching again, but the previous fetch won't stop. Moreover, Task implicitly captures self, which is problematic in this case.
The periodic refresh function has been removed. Instead, a task is created in the view, and will repeatedly call the fetch method. The task gets cancelled when the view disappears.
When the fetch fails, an error message should be displayed. This wasn't handled previously, and isn't now, but a todo has been added and the try has been moved in a do block, instead of failing silently. (I'm assuming the error should be displayed in some kind of notification panel, which doesn't exist atm)
Additionally, an unneeded task has been removed.
Related Issues
None
Checklist