CYF-ITP-South-Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3 | Alarm Clock #267

Simphiwe-Mabuya · 2024-12-31T02:24:47Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

…only when I removed toDo()

… finds largest number

…oop and the test cases all passed

…hing or if we're even required to submit it

…tead

…on for the solution

…ame the solution file in order for my test to pass. I guess it's not necessary now that I got the solution

…g frequency

…houseNumber using the dot notation

…ared a countDown and alarmTimeOut variables

…r minutes is a number and then converted minutes to milliseconds

… what certain lines mean

…a function to update the display time remaining

…est was failing

…y and then rectified a case mismatch in my heading text for the test to pass

…r through their CSS id selectors

…nction and saved it's value to a variable

…author properties

…nd that it matches quotes test expectations in order for the test to pass

…f the closing body tag and that got my second test to pass

Simphiwe-Mabuya added 30 commits December 10, 2024 21:34

Fixed the function implementation by using slice instead of splice

349375a

Installed npm so to be able to run tests

4519e46

Checked what could be making test not to pass

81fbc9f

Removed console.log I sued to check the median value before it's logged

34be16d

Fixed my function so it can handle even length arrays

093ad63

Fixed my test errors on line 11 and line 12

cee8ab1

First implemented the function to sort digits

7a1068a

Rectified function implementation from sort() elements to Set() elements

8d85c91

Renamed my function parameter from dupe to array for clarity purposes

7c7ac9a

Created an export line for my dedupe function

c2aaaf0

Created first dedupe test to check for an empty string and it passed …

583f7db

…only when I removed toDo()

Added a semi colon at the end of line 9

78edc0a

Created three more test cases and got them to pass

83f24b8

Created a findMax function that is able to handle different cases and…

5578f85

… finds largest number

Wrote a comment on line 2 about filtered elements

77b0dd0

Wrote first max test case to see if it will pass and it passed

d110f8f

Created the rest of the max tests and they all passed

1bef09a

Created a function that sums up the numerical elements of an array

3f9d828

Added a line to filter number elements only on line 5

d51c233

Created the first sum test case and it passed

31aae92

Created the rest of the sum test cases and they all passed

d9aabbf

Refactored the implementation of the function by using the for...of l…

8cda024

…oop and the test cases all passed

I am trying to solve this kata but not sure if I am doing the right t…

89cc599

…hing or if we're even required to submit it

Undid the entire tedious step and I'll try using the sum function ins…

dbd155a

…tead

Modified the sum function and implemented a resultingFrequency functi…

2276bf9

…on for the solution

Created a resulting-frequency test file

1c5ca52

Deleted the resulting-frequency test file cause it meant I had to ren…

a0906de

…ame the solution file in order for my test to pass. I guess it's not necessary now that I got the solution

Fed the puzzle input into my function and got the solution / resultin…

866f327

…g frequency

Fixed the code by removing the square bracket notation and appending …

933db27

…houseNumber using the dot notation

Added a comment explaining why the code wasn't working.

e683136

Simphiwe-Mabuya added 13 commits December 21, 2024 02:06

Created a till.test file

5339cb8

Added an exports line for my function

e8495c4

Wrote my first totalTill test case and it passed

e39918d

Updated my function to throw an error when an invalid object is passed

22f7be9

Wrote more totalTill test cases and they all passed

4b95ad5

Started by accessing #timeRemaining and #alarmSet elements, then decl…

62b36ff

…ared a countDown and alarmTimeOut variables

Implemented the setAlarm function by first ensuring that the value fo…

d8cfffb

…r minutes is a number and then converted minutes to milliseconds

Added a comment on line 7

db41e09

Implemented the startCountDown function and added comments to explain…

37c2f37

… what certain lines mean

Updated HTML title to Alarm Clock

cec37ab

Deleted line 4 declaration for I didn't need it and then implemented …

04b0be5

…a function to update the display time remaining

Installed / Updated the @testing-library/jest-dom module because my t…

92b0438

…est was failing

Fixed / updated my function so to handle minutes and seconds correctl…

fb748c8

…y and then rectified a case mismatch in my heading text for the test to pass

Simphiwe-Mabuya added the Needs Review Participant to add when requesting review label Dec 31, 2024

Simphiwe-Mabuya linked an issue Dec 31, 2024 that may be closed by this pull request

[TECH ED] Build alarmclock app Simphiwe-Mabuya/My-Coursework-Planner#50

Open

6 tasks

Simphiwe-Mabuya added 13 commits January 2, 2025 22:39

I added a console log on line 493 to check what the function will print

ec05e8c

Updated the title element to "Quote generator app"

401eae9

Removed the console.log I used to call pickFromArray on line 493

c17a695

Accessed the quote, the author and button elements using querySelecto…

0558754

…r through their CSS id selectors

Implemented an addEventListener function, called the pickFromArray fu…

a59f08c

…nction and saved it's value to a variable

Placed my event listener outside my function then accessed quote and …

8c1964e

…author properties

Correctly accessed quote and author the randomQuote variable

3f7264a

Updated my code by making sure the quote on index 2 displays onload a…

fed38b8

…nd that it matches quotes test expectations in order for the test to pass

Updated my code to first load quote on index 2

02d86c9

Removed the debugging line from line 41

eed179f

Removed my script tag from inside the head parent and placed on top o…

e6db122

…f the closing body tag and that got my second test to pass

Tried to add an import line then removed it because it was not needed

27de916

Updated a comment on line 40 regarding the first quote

aff004c

Simphiwe-Mabuya closed this Jan 6, 2025

Simphiwe-Mabuya deleted the feature/Sprint-3 branch January 6, 2025 22:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CYF-ITP-South-Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3 | Alarm Clock #267

CYF-ITP-South-Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3 | Alarm Clock #267

Simphiwe-Mabuya commented Dec 31, 2024

CYF-ITP-South-Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3 | Alarm Clock #267

CYF-ITP-South-Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3 | Alarm Clock #267

Conversation

Simphiwe-Mabuya commented Dec 31, 2024

Learners, PR Template

Changelist

Questions