northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3 #224

RahwaZeslusHaile · 2024-12-09T19:45:21Z

northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3

codrex · 2024-12-10T19:32:45Z

Sprint-2/debug/2.js

@@ -1,8 +1,9 @@
 // Predict and explain first...
+// the num is already declared by the constant keyword ,which is not going to change in every logging.


While your implementation is correct, your explanation does not clearly explain the reason for the bug. Please give your code a second look and update your explanation.

codrex · 2024-12-10T19:43:01Z

Sprint-2/implement/bmi.js

@@ -13,3 +13,10 @@
 // Given someone's weight in kg and height in metres
 // Then when we call this function with the weight and height
 // It should return their Body Mass Index to 1 decimal place
+function BMICalculation(height,adultWeight){
+const heightSquare= Math.sqrt(height);


Your BMI implementation is wrong. You are doing something incorrectly with your height. Please look up the correct formula for BMI calculation.

codrex · 2024-12-10T19:47:49Z

Sprint-2/implement/cases.js

@@ -13,3 +13,8 @@

 // You will need to come up with an appropriate name for the function
 // Use the string documentation to help you find a solution
+function changeToUpper(words){


Can you come up with a more descriptive name for this function? changeToUpper does not clearly describe what the function is doing

codrex · 2024-12-10T19:56:09Z

Sprint-2/implement/to-pounds.js

+}
+
+console.log(toPounds("90P"))
+


It would be best if you also handled edge cases like empty strings, missing "P", or invalid input.

codrex · 2024-12-10T20:04:30Z

Sprint-2/implement/vat.js

@@ -8,3 +8,8 @@
 // Given a number,
 // When I call this function with a number
 // it returns the new price with VAT added on
+function priceWithoutVAT(price){
+  priceWithVAT=price+ (price*0.2);


Can you make sure priceWithVAT is properly declared

RahwaZeslusHaile · 2024-12-14T23:54:39Z

thank you for your constructive reviews, I updated with the corrected one .

RahwaZeslusHaile · 2024-12-16T23:18:31Z

Please take a look when you have the chance and let me know if there are any improvements or issues you see. Thanks in advance

cjyuan · 2024-12-19T23:49:45Z

@RahwaZeslusHaile I think you can tag the reviewer (like what I did here with your ID) to let the reviewer know you would like a follow-up review from the reviewer.

cjyuan

The code is quite solid.
card-validator.md has a bug that needs fixing.

cjyuan · 2025-01-02T17:49:52Z

Sprint-3/implement/get-angle-type.js

 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+function getAngleType(angleMeasure){
+
+   if (angleMeasure === 90){
+      return "Right_Angle";
+    }
+   else if (angleMeasure < 90) { 
+        return "Acute angle"; 
+      } 
+   else if (angleMeasure > 90 && angleMeasure < 180) { 
+      return "Obtuse angle"; 
+    } 
+   else if (angleMeasure===180) { 
+        return "Straight angle"; 
+      }  
+   else if (angleMeasure > 180) { 
+        return "Reflex angle"; 
+      }  
+}


What do you expect from the following function calls?

getAngleType(360) getAngleType(1000) getAngleType(0) getAngleType(-1000)

If the spec is not clear about how to classify 0 or negative angles, you can lookup the definition of "Acute angle".

Yes I understand ,I didn't see that way. So what I have done in this new code is try to change the degrees to to an equivalent angle within the standard range of
0 degree to 360 degree

cjyuan · 2025-01-02T17:50:58Z

Sprint-3/implement/get-angle-type.js

+console.log(getAngleType(90))
+console.log(getAngleType(110))
+console.log(getAngleType(10))
+console.log(getAngleType(180))
+console.log(getAngleType(200))


Do you notice any inconsistency among the output produced by these statements?

cjyuan · 2025-01-02T17:58:04Z

Sprint-3/implement/get-card-value.js

+    if (!isNaN(rank) && Number(rank) >= 2 && Number(rank) <= 10) {
+        return Number(rank);
+    }


What do you expect from the following function calls?
Does your function return the value you expected?

getCardValue("010♠"); getCardValue("02♠"); getCardValue("0x02♠"); getCardValue("2.1♠")

cjyuan · 2025-01-02T18:10:02Z

Sprint-3/implement/is-valid-triangle.js

+    if(a <= 0 || b <= 0 || c <= 0){
+        return false;
+    }


If any of a, b, and c is less than or equal to zero, then the condition at line 43 will always be false.
Is there any need to further check if a, b, and c is less than or equal to zero at line 51?

I will not go into details why in some programming languages (but not JavaScript) we need also to ensure a, b, c are positives.

cjyuan · 2025-01-02T18:13:35Z

Sprint-3/implement/rotate-char.js

+    if (char >= "a" && char <= "z") {
+        // Calculate new character with wraparound
+        const charCode = char.charCodeAt(0);
+        const rotatedCode = ((charCode - 97 + shift) % 26) + 97; // 'a' starts at ASCII 97


This approach is good.
If shift were allowed to be negative so that charCode - 97 + shift can become a negative number, how would you modify your code to deal with negative shift?

cjyuan · 2025-01-02T18:18:50Z

Sprint-3/revise/implement/card-validator.md

+function validateCreditCard(cardNumber) {
+    if (cardNumber.length !== 16) {
+        return false;
+    }
+
+    const digitSet = new Set(cardNumber);
+    if (digitSet.size < 2) {
+        return false;
+    }
+
+
+    const lastDigit = parseInt(cardNumber.charAt(cardNumber.length - 1), 10);
+    if (lastDigit % 2 !== 0) {
+        return false;
+    }
+
+
+    let sum = 0;
+    for (let i = 0; i < cardNumber.length; i++) {
+        sum += parseInt(cardNumber.charAt(i), 10);
+    }
+
+    if (sum <= 16) {
+        return false;
+    }
+
+    return true;
+}


Have you fully tested this function? It missed checking something in the given cardNumber.

cjyuan · 2025-01-02T18:32:35Z

Sprint-3/revise/implement/is-prime.js

+
+function isPrimeNumber(number) {
+    if (number <= 1) {
+        throw new Error('There is no negative prime number or zero as a prime number.');


How are these non-prime numbers (e.g., -100, 1, 0) any different from other non-prime numbers (e.g., 10, 15, 100)?

cjyuan · 2025-01-02T18:36:07Z

Sprint-3/revise/implement/is-prime.js

+        return false;
+    }
+
+    for (let index = 3; index <= Math.sqrt(number); index += 2) {


You can possibly improve the performance of the code in the following manner:

Avoid calling Math.sqrt(num) repeatedly by assigning the value of Math.sqrt(num) to a variable once, and then refer to the variable in the condition of the loop.

Note: The condition is checked at the start of every iteration.

cjyuan · 2025-01-02T18:40:43Z

Sprint-3/revise/implement/password-validator.test.js

+    const previousPasswords = ['Password1!', 'Admin123#'];
+
+      it('should return false for passwords with less than 5 characters', () => {
+        expect(isValidPassword('P1!', previousPasswords)).toBe(false);


The function could have also returned false because P1! does not contain any lowercase letter. How can we be 100% sure the function can correctly check passwords shorter than 5 characters?

cjyuan · 2025-01-02T18:44:12Z

Sprint-3/revise/implement/repeat.js

+    if (count === 0) {
+        return '';
+    }
+    if (count === 1) {
+        return str;
+    }
+    return str.repeat(count);


These statements could be greatly shorten if you know how String.repeat() works.

RahwaZeslusHaile added 8 commits October 29, 2024 22:32

sprint2Exercises

fe5ab9e

the function to identify the angle

dc58894

a java script code to identify the validity of function

89ced3f

writing different assertion for a function getCardValue

f1d08ce

a function that identify the validness of triangle

051dde0

a function that shifts value and character as input

2596718

updated

dede04f

updated

4d3a429

codrex self-requested a review December 10, 2024 19:33

codrex requested changes Dec 10, 2024

View reviewed changes

RahwaZeslusHaile added 5 commits December 14, 2024 22:52

Explanation reason for the bug with the correct code

81f1dc7

correct BMI calculation

968ebe1

Making the function more descriptive

00be24d

handling edge cases

a31b23f

Proper Declaration

c8e6bb1

RahwaZeslusHaile added 10 commits December 15, 2024 20:20

A function and a test to count the char

e551597

Function to get ordinary number

7b89028

different file name for js and test.js

b9c04de

A function to get ordinal number with test

b482ac3

A function to check if the given number is prime or not

2f1cb35

a test for ordinal number

6bf3fbb

A function to check the password validation

1f64f33

A function and test to repeat the string

0842687

while loop statement

7a67c3b

credit card validator

9099e59

RahwaZeslusHaile added the Needs Review Participant to add when requesting review label Dec 17, 2024

cjyuan mentioned this pull request Jan 2, 2025

northwest |Rahwa Zeslus |module-structure-and-Testing-Data|week2 #226

Open

5 tasks

cjyuan reviewed Jan 2, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 2, 2025

A function to get an Angle Type

0e8952c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3 #224

northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3 #224

RahwaZeslusHaile commented Dec 9, 2024 •

edited

Loading

codrex Dec 10, 2024

codrex Dec 10, 2024

codrex Dec 10, 2024

codrex Dec 10, 2024

codrex Dec 10, 2024

RahwaZeslusHaile commented Dec 14, 2024

RahwaZeslusHaile commented Dec 16, 2024

cjyuan commented Dec 19, 2024

cjyuan left a comment

cjyuan Jan 2, 2025

RahwaZeslusHaile Jan 4, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

cjyuan Jan 2, 2025

		@@ -1,8 +1,9 @@
		// Predict and explain first...
		// the num is already declared by the constant keyword ,which is not going to change in every logging.

		}

		console.log(toPounds("90P"))

northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3 #224

Are you sure you want to change the base?

northwest |Rahwa Zeslus |module-structure-and-Testing-Data | WEEK3 #224

Conversation

RahwaZeslusHaile commented Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RahwaZeslusHaile commented Dec 14, 2024

RahwaZeslusHaile commented Dec 16, 2024

cjyuan commented Dec 19, 2024

cjyuan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RahwaZeslusHaile commented Dec 9, 2024 •

edited

Loading