Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London|Phone Naing|Module-User-Focus-Data-Form|Week2 #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mgphone
Copy link

@Mgphone Mgphone commented Nov 2, 2024

Learners, PR Template

Self checklist

  • [✅ ] I have committed my files one by one, on purpose, and for a reason
  • [ ✅] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ ✅] I have tested my changes
  • [ ✅] My changes follow the style guide
  • [✅ ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit e3cf7af
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/672b63cf039a4200088d102d
😎 Deploy Preview https://deploy-preview-307--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mgphone Mgphone changed the title add form control index and css and checklist London|Phone Naing|Module-User-Focus-Data-Form|Week2 Nov 2, 2024
@Mgphone Mgphone added the Needs Review Participant to add when requesting review label Nov 4, 2024
Copy link

@mrvicthor mrvicthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mgphone ,
Excellent work here. I have left a few comments for you to address in your CSS file.
Happy to approve once this is resolved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mgphone ,
Fantastic work here with the form.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mgphone ,
May I suggest that you use rem instead of px for other css properties. It is advisable to use px for elements with fixed size (for example, border, and box-shadow).

Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrvicthor
I have just changed all to rem :)

Thanks.

@mrvicthor mrvicthor added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 5, 2024
@Mgphone Mgphone added the Complete Participant to add when work is complete and review comments have been addressed label Nov 6, 2024
Copy link

@mrvicthor mrvicthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mgphone ,
Looks good to me.
Happy to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants