Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WestMidlands| Ruei Ruei| Rueimadut/Module-User-Focused-Data|week2 #312

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Rueimadut
Copy link

@Rueimadut Rueimadut commented Nov 5, 2024

completed form control website

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit a6ce28e
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/672a5399a6e4930008b5b516
😎 Deploy Preview https://deploy-preview-312--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rueimadut Rueimadut added the Needs Review Participant to add when requesting review label Nov 5, 2024
@cjyuan
Copy link

cjyuan commented Nov 5, 2024

How come your repo has 27 changed files. I am expected changes files in /form-controls only.

The form looks good in general. Can you prepare the form to support these two acceptance criteria:

  • I require a valid name. I have defined a valid name as a text string of two characters or more.
  • I require one date from a constrained date range.
    • Since we can't obtain the current date without using JavaScript, you may assume the current date is 1/11/2024 and constrain the selectable date to be within 4 weeks of 1/11/2024.

This is extra request: Can you make all input fields the same width? And ideally having same space on each side of every input field. That will make the form look nicer.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review 👀 Review Requirements Changes requested to meet requirements and removed Needs Review Participant to add when requesting review labels Nov 5, 2024
@Rueimadut Rueimadut marked this pull request as ready for review November 5, 2024 12:06
@Rueimadut
Copy link
Author

made some changes to the form

@Rueimadut Rueimadut added the Complete Participant to add when work is complete and review comments have been addressed label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed 👀 Review Requirements Changes requested to meet requirements Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants