Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF-London | seerat junaid | Module-User-Focused-Data | Week 1 #313

Closed

Conversation

seeratjunaid
Copy link

@seeratjunaid seeratjunaid commented Nov 5, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

  • Used semantic HTML tags to structure the webpage
  • Created a page header with a title and description
  • Created an articles section with three articles, each including a title, summary, and a link
  • Created a page footer and fix it to the bottom of the viewport
  • Used the :first-child pseudo-class to style the first article so that it stands out from the others
  • Used version control by committing often and pushing regularly to GitHub

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit ff1b74a
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/672ff1a3d247780008d63ea5
😎 Deploy Preview https://deploy-preview-313--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShayanMahnam ShayanMahnam added the Needs Review Participant to add when requesting review label Nov 8, 2024
<div class="foot">
<p>seerat fatima</p>
<p><a href="https://github.com/">GitHub</a></p>
Copy link

@giorgigutsaevi giorgigutsaevi Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a slight nitpick here, but if you use just the anchor tag <a> here, you could technically remove the surrounding <p> from around it. More precisely, it's not a necessity to wrap all your anchor tags in paragraph tags in HTML.

Copy link

@giorgigutsaevi giorgigutsaevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one here! 🎉 Congrats on completing this assignment with flying colours!

You have showcased a solid understanding of HTML & CSS which is the foundation of great User Experience (or UX in short) in modern Web Development.

My humble advice would be for you to get familarised with the topics of Accessibility and Semantics even deeper and how they come into play in modern web development. There is governing body that curates and dictates the conventions and standards when it comes to Website Accessibility, I will leave this link here for your to investigate. 🕵

The general goal is to make the website as easy-to-use for the users as possible. So, having said this, following Accessibility conventions and patterns will eventually prove to make your website better-optimised and ultimately a great user experience, which is paramount and very important in our field.

You can make use of the Lighthouse, it's a tool built by Google devs to run performance, accessibility and SEO checks against your website and once it's done, it will analyse your website and give you a score. It also gives you some recommendations based on your codebase, and is an amazing tool to make your website run smooth 😊

There are other tools similar like Lighthhouse, I will leave that research up to you :)

@giorgigutsaevi giorgigutsaevi added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 8, 2024
@seeratjunaid seeratjunaid deleted the feature/wireframe branch November 10, 2024 00:29
@seeratjunaid seeratjunaid restored the feature/wireframe branch November 10, 2024 01:39
@seeratjunaid seeratjunaid reopened this Nov 10, 2024
@seeratjunaid seeratjunaid added the Complete Participant to add when work is complete and review comments have been addressed label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants