-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYF-London | seerat junaid | Module-User-Focused-Data | Week 1 #313
Conversation
✅ Deploy Preview for cyf-ufd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wireframe/index.html
Outdated
<div class="foot"> | ||
<p>seerat fatima</p> | ||
<p><a href="https://github.com/">GitHub</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a slight nitpick here, but if you use just the anchor tag <a>
here, you could technically remove the surrounding <p>
from around it. More precisely, it's not a necessity to wrap all your anchor tags in paragraph tags in HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one here! 🎉 Congrats on completing this assignment with flying colours!
You have showcased a solid understanding of HTML & CSS which is the foundation of great User Experience (or UX in short) in modern Web Development.
My humble advice would be for you to get familarised with the topics of Accessibility and Semantics even deeper and how they come into play in modern web development. There is governing body that curates and dictates the conventions and standards when it comes to Website Accessibility, I will leave this link here for your to investigate. 🕵
The general goal is to make the website as easy-to-use for the users as possible. So, having said this, following Accessibility conventions and patterns will eventually prove to make your website better-optimised and ultimately a great user experience, which is paramount and very important in our field.
You can make use of the Lighthouse, it's a tool built by Google devs to run performance, accessibility and SEO checks against your website and once it's done, it will analyse your website and give you a score. It also gives you some recommendations based on your codebase, and is an amazing tool to make your website run smooth 😊
There are other tools similar like Lighthhouse, I will leave that research up to you :)
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.