CYF-London | Pooriya Ketabi | Module-User-Focused-Data | WEEK 2

[PooriyaKTB]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cyf-ufd ready!

Name	Link
🔨 Latest commit	4a1d74e
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-ufd/deploys/6741d6264518970009b1dd6f
😎 Deploy Preview	https://deploy-preview-314--cyf-ufd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[prabhveer-mujral]

Interesting variety of design choices in this project!

• Good use of semantics when using html.
• All inputs have associated labels.
• Validation works on all forms apart form the name, where numbers are allowed
• Colour selection works well
• Size selection works from the list with 'small' being disabled as expected
• Date range selection works
• Lighthouse score of only 89/100, mainly due to the styling.
• Chrome Devtools show that there are some unused declarations in css, may be worth having a look if you want to refactor

Nice to see that you have added your own forms in, good exploration!
One thing about the styling choice, having colours such as these may not be very accessible, so next time try to keep styling simpler.