Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF-London | Birhan Mesfen | Module-User-Focused-Data | Week 1 #321

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Birhan-lab
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Html and Css file added
  • Readme updated

Questions

Ask any questions you have for your reviewer.

London | Birhan Mesfen | form exercise | WEEk 2
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit f24555b
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/6756f74cbe926d0008771d7c
😎 Deploy Preview https://deploy-preview-321--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Birhan-lab Birhan-lab added the Needs Review Participant to add when requesting review label Nov 12, 2024
Wireframe/css/style.css Outdated Show resolved Hide resolved
Copy link

@mrvicthor mrvicthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Birhan-lab ,
Excellent work here.
However, I have a left a few comments for you to address.

@mrvicthor mrvicthor added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants