Glasgow | Iakub Dubachev | Module -User-Focused-Data |My portfolio #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-developer-portfolio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glasgow | Iakub Dubachev | Module -User-Focused-Data |My portfolio
Self checklist
I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task
Changelist
In this pull request (PR), I implemented a modern, accessible portfolio design for Iakub Dubachev. The key changes include:
HTML Structure: Utilized semantic HTML5 elements for better accessibility and SEO, including header, main, section, and footer tags. Improved navigation with clear ARIA labels.
CSS Styling: Created a clean and responsive design using the Inter font, ensuring high contrast and readability. Added focus states for interactive elements to enhance accessibility.
Performance Enhancements: Optimized loading of Google Fonts and streamlined CSS to improve rendering speed.
Accessibility Improvements: Focused on high-contrast colors, clear visual hierarchy, and outlined focus styles for keyboard navigation.
Overall, this PR aims to enhance user experience, accessibility, and search engine visibility while ensuring a polished and professional look.
Questions
Anything needs a change