Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding to assist with script loading #28

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

40thieves
Copy link
Contributor

As discussed in this PR review discussion, we don't think trainees will have much experience with importing code (especially considering that various projects use HTML, ESM and/or ESM with JSON import attributes). Therefore this PR provides scaffolding which demonstrates importing basics.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks for picking this up!

Project-Music-Data/index.html Show resolved Hide resolved
@40thieves 40thieves merged commit da8b049 into main Jan 25, 2025
@40thieves 40thieves deleted the feat/add-scaffolding-with-script-loading branch January 25, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants