Fixed wrong channels and buggy disconnects in Firefox

CoderLine · Aug 16, 2021 · 70eb7c3 · 70eb7c3
1 parent 63f47c2
commit 70eb7c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/platform/javascript/AlphaSynthAudioWorkletOutput.ts b/src/platform/javascript/AlphaSynthAudioWorkletOutput.ts
@@ -149,10 +149,13 @@ export class AlphaSynthAudioWorkletOutput extends AlphaSynthWebAudioOutputBase {
         // create a script processor node which will replace the silence with the generated audio
         ctx.audioWorklet.addModule(Environment.scriptFile!).then(
             () => {
-                this._worklet = new AudioWorkletNode(ctx!, 'alphatab');
+                this._worklet = new AudioWorkletNode(ctx!, 'alphatab', {
+                    numberOfOutputs: 1,
+                    outputChannelCount: [2]
+                });
                 this._worklet.port.onmessage = this.handleMessage.bind(this);
 
-                this._source!.connect(this._worklet, 0, 0);
+                this._source!.connect(this._worklet);
                 this._source!.start(0);
                 this._worklet.connect(ctx!.destination);
             },
@@ -178,7 +181,8 @@ export class AlphaSynthAudioWorkletOutput extends AlphaSynthWebAudioOutputBase {
     public pause(): void {
         super.pause();
         if (this._worklet) {
-            this._worklet.disconnect(0);
+            this._worklet.port.onmessage = null;
+            this._worklet.disconnect();
         }
         this._worklet = null;
     }

diff --git a/src/platform/javascript/AlphaSynthWebAudioOutputBase.ts b/src/platform/javascript/AlphaSynthWebAudioOutputBase.ts
@@ -103,7 +103,7 @@ export abstract class AlphaSynthWebAudioOutputBase implements ISynthOutput {
     public pause(): void {
         if (this._source) {
             this._source.stop(0);
-            this._source.disconnect(0);
+            this._source.disconnect();
         }
         this._source = null;
     }