Feature/49 sign up verification

[craineum]

Pull Request

Story

Fix #49

Description

Add sign up email verification

Screenshots

Affected Areas

List out the areas affected by your code change.

Tests

Describe the tests.

Was this feature tested on all browsers?

• Chrome
• Firefox
• Edge
• Internet Explorer
• Safari

Related PRs

Add any related pull requests

Definition of Done

• README updated
• Tests written
• Acceptance criteria implement
• Code reviewed
• Feature accepted

PR Comments Emoji Legend

😻 - :heart_cat_eyes: Compliment to code/idea/etc
♻️ - :recycle: Non-blocking proposed refactor
➕ - :heavy_plus_sign: Non-blocking proposed addition
🔥 - :fire: Non-blocking proposed removal
❓ - :question: Non-blocking question
⚠️ - :warning: Blocking comment that must be addressed before PR

Gifs for life (required)

[archae0pteryx]

LGTM!
just an aside, you can do user?.thing now instead of user && user.thing
also, do you think it might be worthwhile to create a mapping of response errors?

const API_ERRORS = {
  EXPECTED_SOMETIMES_ERROR: "Sometimes this will happen",
  ...
}

So that we're not matching response.error === "i didnt do something" like this (potentially in multiple places), instead matching response.error === API_ERRORS.EXPECTED_SOMETIMES... . I mention it cause it's bitten me in the past - I've had a few components matching the same string for response errors... Probably overkill at this time but thought i'd throw it out there since i saw that here.

[craineum]

@archae0pteryx
Thanks for the feedback. I had thought about coming back around and figuring out how to share data between the api and the web for things like error mapping, but completely forgot, so thanks for the reminder!

[craineum]

Opened a new Issue #104 for handling the error response messages between api and web sides.