Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature/50 Forgot Password Recovery Email #107

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

nataliadiaz2
Copy link
Collaborator

@nataliadiaz2 nataliadiaz2 commented Oct 26, 2022

Story

Fix #50

Description

-Forgot password sends the user an email to reset password
-Email should contain reset token and direct to reset password page

Solution

-Update Auth for forgot password handler.
-Add email setup for user to reset password through link with reset token

Screenshots

Screenshot 2022-10-26 at 9 19 57 AM

Affected Areas

Functions/Auth, Emails, Forgot Password page, env example

Was this feature tested on all browsers?

  • Chrome
  • Firefox
  • Edge
  • Internet Explorer
  • Safari

Definition of Done

  • README updated
  • Tests written
  • Acceptance criteria implement
  • Code reviewed
  • Feature accepted

PR Comments Emoji Legend

😻 - :heart_cat_eyes: Compliment to code/idea/etc
♻️ - :recycle: Non-blocking proposed refactor
➕ - :heavy_plus_sign: Non-blocking proposed addition
🔥 - :fire: Non-blocking proposed removal
❓ - :question: Non-blocking question
⚠️ - :warning: Blocking comment that must be addressed before PR

Gifs for life (required)

mandatory

@archae0pteryx archae0pteryx temporarily deployed to redwood-temp-app-pr-107 October 26, 2022 17:19 Inactive
Copy link
Contributor

@craineum craineum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few changes.

api/src/emails/forgot-password.ts Outdated Show resolved Hide resolved
api/src/emails/forgot-password.ts Outdated Show resolved Hide resolved
api/src/emails/forgot-password.ts Outdated Show resolved Hide resolved
api/src/emails/forgot-password.ts Outdated Show resolved Hide resolved
api/src/functions/auth.ts Outdated Show resolved Hide resolved
@archae0pteryx archae0pteryx temporarily deployed to redwood-temp-app-pr-107 October 26, 2022 21:46 Inactive
Copy link
Contributor

@craineum craineum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@craineum craineum merged commit 0eac897 into main Oct 27, 2022
@craineum craineum deleted the feature/50-forgot-password branch October 27, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Forgot Password Email
3 participants