Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundler picking with optional CLI argument #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaeldll
Copy link

Hey there, thanks for the tool. In my case, I just needed to test for ESBuild tree shaking, but it seems like running the tool automatically checks all three bundlers.
So I added this simple snippet of code to add a CLI argument in the format -r -w -e or any combination of these to add a bundler picking functionality.

@michaeldll
Copy link
Author

Note: I'm a novice to node.js, hopefully this is a proper way to do it haha

@CodyJasonBennett
Copy link
Owner

Thanks for the PR. I'll want to prefer full names to prevent clashes (e.g. Rolldown in the future), but I'm curious what use-case you're targeting solely ESBuild for. Would you prefer a programmable API from a maintainer perspective or are you using this to track down troublesome dependencies as a user?

@michaeldll
Copy link
Author

Meant to answer earlier, sorry for the delay.

Anyways, no problem, thanks for your reply. I agree that full names is a better option, I'll add it.
Of the two use-cases you mentioned, mine is closest to tracking down troublesome dependencies as a user.
Basically, the script stopped working as soon as I ran it because it threw an error while checking for Rollup. I therefore wanted a way to avoid errors in other bundlers and just check for the one(s) I use.

Hopefully that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants