Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): new navigation structure #2211

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

feat(UI): new navigation structure #2211

wants to merge 74 commits into from

Conversation

maiwald
Copy link
Collaborator

@maiwald maiwald commented Oct 11, 2024

This PR adds the app layout proposed by Shapefield's redesign.

@github-actions GitHub Actions
Copy link

LCOV of commit c79d219 during Continuous Integration #3990

Summary coverage rate:
  lines......: 65.5% (14012 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch from c79d219 to 24d5006 Compare October 14, 2024 15:47
@github-actions GitHub Actions
Copy link

LCOV of commit 24d5006 during Continuous Integration #4002

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 2 times, most recently from c7987e5 to 7aef24f Compare October 15, 2024 15:16
@github-actions GitHub Actions
Copy link

LCOV of commit c7987e5 during Continuous Integration #4013

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 7aef24f during Continuous Integration #4014

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch from 7aef24f to 873dd7d Compare October 16, 2024 12:37
@github-actions GitHub Actions
Copy link

LCOV of commit 873dd7d during Continuous Integration #4021

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch from 873dd7d to 3ff6333 Compare October 16, 2024 13:13
@github-actions GitHub Actions
Copy link

LCOV of commit 3ff6333 during Continuous Integration #4023

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 5 times, most recently from 7791446 to e7dd4d4 Compare October 17, 2024 14:11
@maiwald maiwald changed the base branch from update-bootstrap-ui-library to main October 18, 2024 08:57
@maiwald maiwald force-pushed the new-navigation-structure branch from e7dd4d4 to 2b81966 Compare October 18, 2024 10:08
@github-actions GitHub Actions
Copy link

LCOV of commit 2b81966 during Continuous Integration #4044

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 3 times, most recently from af52890 to 7d91b52 Compare October 28, 2024 13:41
@github-actions GitHub Actions
Copy link

LCOV of commit af52890 during Continuous Integration #4058

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 7d91b52 during Continuous Integration #4059

Summary coverage rate:
  lines......: 65.5% (14026 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch from 7d91b52 to 9c65396 Compare October 28, 2024 15:34
@github-actions GitHub Actions
Copy link

LCOV of commit 9c65396 during Continuous Integration #4061

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 2 times, most recently from 6ed7199 to 26741fb Compare October 29, 2024 10:37
@github-actions GitHub Actions
Copy link

LCOV of commit 26741fb during Continuous Integration #4064

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch from 26741fb to 88027da Compare October 29, 2024 13:43
maiwald and others added 28 commits January 3, 2025 11:15
@maiwald
Add listView/detailView panel resizing
6c92e8f
@JoachimTillessen @maiwald
apply design changes to rebased code
722390c
@JoachimTillessen @maiwald
Style resize handle
00631c0
@JoachimTillessen @maiwald
Remove scss file extension from import statement
2281977
@JoachimTillessen @maiwald
Change input bg color, update styleguide
0ebe0cf
@JoachimTillessen @maiwald
Change input bg color for selects and checkboxes
6d3e9bb
@JoachimTillessen @maiwald
apply paper color to numerous elements
70ba5cc
@maiwald
Fix additional popover Header breaking rounded border
5a6d2fb 
The first <Popover.Header> is not the first DOM node in the <Popover>.
React bootstrap prepends another element for the arrow, so :first-child
does not work here.

I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)`
but I suppose our css preprocessor does not support the relatively new
nth-of selector, because the selector is mangled in the compiled output.

https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
@maiwald
Rework tab layout editing to proper drag and drop
ea996c2 
This patch introduces the TabLayoutEditor component with a
drag-and-drop interface for reordering and hiding/showing tabs.

The component accepts an ItemComponent via the `getItemComponent` prop
for rendering individual items.

With this patch we no longer need to manage the synthetic 'hidden' Tab
when no tabs are currently hidden. This is now the editor component's
responsibility and using code does not have to manage that.

This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a
unique scope for each instance of the editor, because drag-and-drop is
only supposed to work within a specific visible/hidden list combination
and not globally across editors.

State changes are now propagated via the `onLayoutChange` callback and
not by reaching into the state of the component.
@maiwald
Simplify calculating visible and hidden lists from layout in Elements…
033547d 
…List
@JoachimTillessen @maiwald
provisory button for collapse function
7dab490
@maiwald
Convert Elements to a function component
1b46052
@maiwald
Add element list collapse button functionality
cd8759c
@maiwald
Fix elements container size
7b37e6a 
The Panel components would not be sized properly before. Now they
receive `width: 0` so flex can calculate the size and scrolling is
handled by a separate wrapper.
@maiwald
Add recommended id and order props to resizable panels
6d82273 
Also fix warning about invalid layout when detail view is not showing.
@JoachimTillessen @maiwald
Style UI for collapse functions
46a91b0
@maiwald
Move managing/context actions back to the top bar
41fe5d7
@maiwald
Merge Scan/PrintCodeButton again
8f046f9
@JoachimTillessen @maiwald
use actual chemotion logo
180ed4c
@JoachimTillessen @maiwald
Style sidebar
92c5316
@JoachimTillessen @maiwald
improve color nuances for sidebar
d6e975f
@JoachimTillessen @maiwald
Use sheet tabs in Collection Management
45ee6ec
@JoachimTillessen @maiwald
Style TabLayoutEditor
0609935
@JoachimTillessen @maiwald
Introduce TabLayoutButton make usage consistent across all element types
7d4ff85
@JoachimTillessen @maiwald
display elements tables consistently
6cd1d11
@JoachimTillessen @maiwald
Apparently this is the official logo
c71247b
@JoachimTillessen @maiwald
Fix placement of ElementDetailSortTab for SampleDetails
c03676d
@JoachimTillessen @maiwald
Remove duplicate role attribute
b280b29
@maiwald maiwald force-pushed the new-navigation-structure branch from 2488f95 to b280b29 Compare January 3, 2025 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

LCOV of commit b280b29 during Continuous Integration #4275

Summary coverage rate:
  lines......: 66.7% (14327 of 21483 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiwald @JoachimTillessen