Merge pull request #43 from ConnorJamesLow/release/v0.8.0

Release/v0.8.0
ConnorJamesLow · Mar 9, 2023 · de52b1b · de52b1b
2 parents 4b51b66 + 83c4e5e
commit de52b1b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/package/package-lock.json b/package/package-lock.json
diff --git a/package/package.json b/package/package.json
@@ -1,6 +1,6 @@
 {
   "name": "texsaur",
-  "version": "0.7.1",
+  "version": "0.8.0",
   "description": "",
   "types": "./dist/index.d.ts",
   "main": "./dist/index.js",

diff --git a/package/src/index.test.tsx b/package/src/index.test.tsx
@@ -64,6 +64,17 @@ describe('jsx: intrinsic elements', () => {
         expect(div.classList[0]).to.equal('foo');
         expect(div.className).to.equal('foo');
     })
+
+    it('can accept HTMLCollections as children', () => {
+        const parent = <div class="parent">
+            <div class="child"></div>
+            <div class="child"></div>
+            <div class="child"></div>
+        </div>
+        const container = <section>{parent.children}</section>
+        expect(container.children).to.have.a.lengthOf(3);
+        expect(container.children[2].className).to.equal("child");
+    })
 });
 
 describe('jsx: fragments', () => {

diff --git a/package/src/index.ts b/package/src/index.ts
@@ -5,7 +5,7 @@ import * as svg from './svg';
 function __jsx<T extends JSX.HTMLTag = JSX.HTMLTag>(tag: T, properties: RecursivePartial<JSX.IntrinsicElements[T]> | null, ...children: Node[]): HTMLElement
 function __jsx<T extends JSX.SVGTag = JSX.SVGTag>(tag: T, properties: RecursivePartial<JSX.IntrinsicElements[T]> | null, ...children: Node[]): SVGElement
 function __jsx(tag: JSX.Component, properties: Parameters<typeof tag> | null, ...children: Node[]): Node
-function __jsx(tag: JSX.Tag | JSX.Component, properties: { [key: string]: any } | null, ...children: Node[]) {
+function __jsx(tag: JSX.Tag | JSX.Component, properties: { [key: string]: any } | null, ...children: any[]) {
     const { document, Node } = JsxDom;
 
     if (typeof tag === 'function') {
@@ -84,7 +84,7 @@ function __jsx(tag: JSX.Tag | JSX.Component, properties: { [key: string]: any }
             element.appendChild(child);
             continue;
         }
-        if (Array.isArray(child)) {
+        if (typeof child !== 'string' && child?.[Symbol.iterator]) {
             element.append(...child);
             continue;
         }