Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Stop supporting deprecated Portal functions #810

Merged

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 22, 2024

What does this PR do?

Removed support for adding old versions of Modules and Portals
The existing old version Portals and Modules still will continue to work

Related ticket

Fixes #789

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@satyajeetkolhapure satyajeetkolhapure self-assigned this Nov 22, 2024
@alainncls alainncls changed the title [Draft] Chore(contracts): Stop supporting deprecated Portal functions chore(contracts): Stop supporting deprecated Portal functions Nov 22, 2024
@satyajeetkolhapure satyajeetkolhapure marked this pull request as ready for review November 25, 2024 09:06
@satyajeetkolhapure satyajeetkolhapure force-pushed the chore/stop-supporting-deprecated-portal-functions branch from b91c72a to 800c578 Compare November 25, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.32%. Comparing base (b95345a) to head (63f2dc7).

Files with missing lines Patch % Lines
contracts/src/abstracts/AbstractPortalV2.sol 97.05% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #810       +/-   ##
===========================================
+ Coverage   48.96%   75.32%   +26.35%     
===========================================
  Files          18       50       +32     
  Lines         388      920      +532     
  Branches       61      188      +127     
===========================================
+ Hits          190      693      +503     
- Misses        195      224       +29     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls requested a review from a team November 25, 2024 15:13
contracts/src/PortalRegistry.sol Outdated Show resolved Hide resolved
@satyajeetkolhapure satyajeetkolhapure force-pushed the chore/stop-supporting-deprecated-portal-functions branch from 8daf492 to 63f2dc7 Compare November 26, 2024 10:14
@satyajeetkolhapure satyajeetkolhapure merged commit eac2e44 into dev Nov 26, 2024
9 checks passed
@satyajeetkolhapure satyajeetkolhapure deleted the chore/stop-supporting-deprecated-portal-functions branch November 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Stop supporting deprecated Portal functions
3 participants