Escape password in cifs command line

ContainX · Nov 26, 2017 · 23d5996 · 23d5996
1 parent 9092db7
commit 23d5996
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/netshare/drivers/cifs.go b/netshare/drivers/cifs.go
@@ -217,9 +217,10 @@ func (c CifsDriver) mountVolume(name, source, dest string, creds *CifsCreds) err
 	}
 
 	if user != "" {
-		opts.WriteString(fmt.Sprintf("username=%s,", user))
+		// escape single quotes in password character as it will be quoted in command line
+		opts.WriteString(fmt.Sprintf("username='%s',", strings.Replace(user, "'", "\\'", -1)))
 		if pass != "" {
-			opts.WriteString(fmt.Sprintf("password=%s,", pass))
+			opts.WriteString(fmt.Sprintf("password='%s',", strings.Replace(pass, "'", "\\'", -1)))
 		}
 	} else {
 		opts.WriteString("guest,")
@@ -245,7 +246,7 @@ func (c CifsDriver) mountVolume(name, source, dest string, creds *CifsCreds) err
 
 	opts.WriteString(fmt.Sprintf("%s %s", source, dest))
 	cmd := fmt.Sprintf("mount -t cifs -o %s", opts.String())
-	log.Debugf("Executing: %s\n", strings.Replace(cmd, "password="+pass, "password=****", 1))
+	log.Debugf("Executing: %s\n", strings.Replace(cmd, "password='"+pass+"'", "password='****'", 1))
 	return run(cmd)
 }