Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding styles to the demo #1031

Merged
merged 8 commits into from
Nov 1, 2023
Merged

feat: adding styles to the demo #1031

merged 8 commits into from
Nov 1, 2023

Conversation

0xisk
Copy link
Member

@0xisk 0xisk commented Oct 16, 2023 •
edited
Loading

Explanation

This PR adds styles to the demo.

Related Issues

N/A

Screenshots

Expand

Screenshot_20231016_200057

Screenshot_20231016_200108

Screenshot_20231016_200140

Screenshot_20231016_200132

Screenshot_20231016_200126

Screenshot_20231016_200120

Screenshot_20231018_111852

Manual Testing Steps

  • Please go through a regular test to the demo.

Pre-Merge Checklist

Assignees Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

Reviewers Checklist

  • Manual testing checked and passed.

@0xisk 0xisk changed the title Feature/demo styles feature: adding styles to the demo Oct 17, 2023
@0xisk 0xisk added the 🌱 new feature Troubleshooting new feature issues label Oct 17, 2023
@0xisk 0xisk self-assigned this Oct 17, 2023
@0xisk 0xisk added this to the v0.6.0 milestone Oct 17, 2023
@0xmad 0xmad changed the title feature: adding styles to the demo feat: adding styles to the demo Oct 17, 2023
@0xisk 0xisk force-pushed the feature/demo-styles branch from 51501e5 to 4036c2c Compare October 18, 2023 09:22
@0xisk 0xisk marked this pull request as ready for review October 18, 2023 13:10
0xmad
0xmad reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk thanks, there are some comments about styles.

packages/demo/public/index.html Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/demo/src/components/ActionBox/ActionBox.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/ActionBox/ActionBox.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/ActionBox/ActionBox.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/Icon/Icon.tsx Outdated Show resolved Hide resolved
packages/demo/src/static/icons/icon-128.png Outdated Show resolved Hide resolved
packages/demo/src/styles.scss Outdated Show resolved Hide resolved
packages/demo/src/utils/index.ts Outdated Show resolved Hide resolved
packages/demo/src/utils/variables.scss Outdated Show resolved Hide resolved
@0xisk 0xisk force-pushed the feature/demo-styles branch from 02d904d to f993120 Compare October 23, 2023 10:54
@0xisk 0xisk requested a review from 0xmad October 23, 2023 10:57
@0xisk 0xisk force-pushed the feature/demo-styles branch 3 times, most recently from 2bf37b0 to 73f022b Compare October 26, 2023 14:13
@0xisk 0xisk mentioned this pull request Oct 26, 2023
Closed
7 tasks
@0xisk
Copy link
Member Author

0xisk commented Oct 27, 2023

@0xmad The windows build is failing because of the bash script I added.

@0xisk 0xisk force-pushed the feature/demo-styles branch from 9f61f32 to aae52e9 Compare November 1, 2023 14:27
0xmad
0xmad reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk thanks, just few comments

packages/demo/package.json Outdated Show resolved Hide resolved
packages/demo/package.json Show resolved Hide resolved
packages/demo/public/docs/rateLimitingNullifier.ts Outdated Show resolved Hide resolved
packages/demo/public/docs/semaphore.ts Outdated Show resolved Hide resolved
packages/demo/public/docs/semaphore.ts Show resolved Hide resolved
packages/demo/src/components/GetCommitment/GetCommitment.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/RateLimitingNullifier/RateLimitingNullifier.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/Semaphore/Semaphore.tsx Outdated Show resolved Hide resolved
packages/demo/src/components/VerifiableCredentials/VerifiableCredentials.tsx Outdated Show resolved Hide resolved
packages/demo/src/styles/useGlobalStyles.ts Outdated Show resolved Hide resolved
@0xmad
Copy link
Member

0xmad commented Nov 1, 2023 •
edited
Loading

All code examples have this text:
image

This is not a critical and it can be fixed with webpack.

0xmad
0xmad approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk thanks!

@0xmad 0xmad enabled auto-merge (squash) November 1, 2023 18:15
@0xmad 0xmad merged commit 264b8c8 into main Nov 1, 2023
10 checks passed
@0xmad 0xmad deleted the feature/demo-styles branch November 1, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xisk 0xisk

Labels
🌱 new feature Troubleshooting new feature issues
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@0xisk @0xmad