Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #58 IsCompatibleObject #63

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix #58 IsCompatibleObject #63

merged 1 commit into from
Aug 28, 2024

Conversation

zerodev1200
Copy link
Contributor

#58
Fixed an issue where IsCompatibleObject() was always false when T and TView were different types.
This allowed Contains() to work correctly and resolve the issue.

@neuecc
Copy link
Member

neuecc commented Aug 28, 2024

Ah, that's right! The comparison in TView is correct.

@neuecc neuecc merged commit 3488094 into Cysharp:master Aug 28, 2024
@zerodev1200 zerodev1200 deleted the #58 branch August 29, 2024 06:18
zerodev1200 added a commit to zerodev1200/ObservableCollections that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants