Skip to content

Commit

Permalink
tests: move package_revise tests to separate file
Browse files Browse the repository at this point in the history
  • Loading branch information
@paulmueller
paulmueller committed Oct 20, 2021
1 parent 1dd2fe9 commit ac8b022
Show file tree
Hide file tree
Showing 2 changed files with 207 additions and 195 deletions.
195 changes: 0 additions & 195 deletions ckanext/dcor_schemas/tests/test_auth_dataset.py
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import cgi
import copy
import pathlib
import uuid

import pytest

Expand Down Expand Up @@ -47,199 +45,6 @@ def test_dataset_add_resources_only_to_drafts():
)


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_add_resources_only_to_drafts_package_revise():
"""do not allow adding resources to non-draft datasets"""
user = factories.User()
owner_org = factories.Organization(users=[{
'name': user['id'],
'capacity': 'admin'
}])
# Note: `call_action` bypasses authorization!
create_context = {'ignore_auth': False, 'user': user['name']}
test_context = {'ignore_auth': False, 'user': user['name'], "model": model}
# create a dataset
dataset, _ = make_dataset(create_context, owner_org, with_resource=True,
activate=True)
# assert: adding resources to active datasets forbidden
resources = copy.deepcopy(dataset["resources"])
resources.append({"name": "peter.rtdc",
"url": "upload",
"package_id": dataset["id"]})
with pytest.raises(
logic.NotAuthorized,
match="Adding resources to non-draft datasets not allowed"):
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": resources}
})


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_add_resources_only_to_drafts_package_revise_control():
"""do not allow adding resources to non-draft datasets"""
user = factories.User()
owner_org = factories.Organization(users=[{
'name': user['id'],
'capacity': 'admin'
}])
# Note: `call_action` bypasses authorization!
create_context = {'ignore_auth': False, 'user': user['name']}
test_context = {'ignore_auth': False, 'user': user['name'], "model": model}
# create a dataset
dataset, _ = make_dataset(create_context, owner_org, with_resource=True,
activate=False)
# assert: adding resources to draft datasets allowed
resources = copy.deepcopy(dataset["resources"])
resources.append({"name": "peter.rtdc",
"url": "upload",
"sp:chip:channel width": 21.0, # this must be supported
"package_id": dataset["id"]})
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": resources}
})


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_add_resources_set_id_not_allowed_package_revise():
"""do not allow adding resources to non-draft datasets"""
user = factories.User()
owner_org = factories.Organization(users=[{
'name': user['id'],
'capacity': 'admin'
}])
# Note: `call_action` bypasses authorization!
create_context = {'ignore_auth': False, 'user': user['name']}
test_context = {'ignore_auth': False, 'user': user['name'], "model": model}
# create a dataset
dataset, _ = make_dataset(create_context, owner_org, with_resource=True,
activate=False)
# assert: adding resources to active datasets forbidden
resources = copy.deepcopy(dataset["resources"])
resources.append({"name": "peter.rtdc",
"url": "upload",
"package_id": dataset["id"],
"id": uuid.uuid4()})
with pytest.raises(logic.NotAuthorized, match="Invalid resource ID"):
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": resources,
}},
)


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_update_resources_only_for_drafts_package_revise():
"""do not allow editing resources (except description)"""
user = factories.User()
owner_org = factories.Organization(users=[{
'name': user['id'],
'capacity': 'admin'
}])
# Note: `call_action` bypasses authorization!
create_context = {'ignore_auth': False, 'user': user['name']}
test_context = {'ignore_auth': False, 'user': user['name'], "model": model}

# create a dataset
dataset, _ = make_dataset(create_context, owner_org, with_resource=True,
activate=False)
# modifying the description should work
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": [{
"id": dataset["resources"][0]["id"],
"description": "A new description",
"sp:chip:channel width": 21.0, # this must be supported
}
],
}})
helpers.call_action(
"package_revise", test_context,
**{"match__id": dataset["id"],
"update__resources__0": {"description": "A new description",
"sp:chip:channel width": 21.0}
})
# make sure that worked
dataset2 = helpers.call_action("package_show", create_context,
id=dataset["id"])
assert dataset2["resources"][-1]["description"] == "A new description"
assert dataset2["resources"][-1]["sp:chip:channel width"] == 21.0

# modifying anything else should *not* work
with pytest.raises(
logic.NotAuthorized,
match="Editing not allowed: dc:experiment:date=2017-02-09"):
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": [{
"id": dataset["resources"][0]["id"],
"dc:experiment:date": "2017-02-09"}],
}})


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_update_resources_only_for_drafts_package_revise_2():
"""do not allow editing resources (except description)"""
user = factories.User()
owner_org = factories.Organization(users=[{
'name': user['id'],
'capacity': 'admin'
}])
# Note: `call_action` bypasses authorization!
create_context = {'ignore_auth': False, 'user': user['name']}
test_context = {'ignore_auth': False, 'user': user['name'], "model": model}

# create a dataset
dataset, _ = make_dataset(create_context, owner_org, with_resource=True,
activate=True)

# modifying the description should not work for active datasets
with pytest.raises(
logic.NotAuthorized,
match="Changing 'resources' not allowed for non-draft datasets"):
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": [{
"id": dataset["resources"][0]["id"],
"description": "A new description",
}
],
}})

# modifying the RSS should not work for active datasets
with pytest.raises(
logic.NotAuthorized,
match="Changing 'resources' not allowed for non-draft datasets"):
helpers.call_auth(
"package_revise", test_context,
**{"update": {
"id": dataset["id"],
"resources": [{
"id": dataset["resources"][0]["id"],
"sp:chip:channel width": 21.0,
}
],
}})


@pytest.mark.ckan_config('ckan.plugins', 'dcor_schemas')
@pytest.mark.usefixtures('clean_db', 'with_plugins', 'with_request_context')
def test_dataset_create_anonymous():
Expand Down
Loading

0 comments on commit ac8b022

Please sign in to comment.