-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIR-894 : Story – WP – Check your answers – Dead animals #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
teddmason
approved these changes
Nov 18, 2024
sujithvg
added a commit
that referenced
this pull request
Dec 10, 2024
* SIR-888: water-pollution/your-details (#205) Looks good to me :) * SIR-887 : Story – WP – Check your answers (#208) * SIR-888: water-pollution/your-details (#205) Looks good to me :) * WIP - WP CYA Page * Technical implementation for SIR-887 * Fixed all lint errors * Refactored code and added comments * Refactored code and logic update * Added unit tests for check your answers page * SIR-1102 map widget for check your answers (#207) * linting that i missed * Fixed unit test case issues * fixing unit tests * reverting date test am and AM having issues * CYA routing boilerplate * changing to form-layout otherwise post doesn''t work * Fixed sonar issues part 1 * Fixed lint issues * Fixed sonar issues part 2 * Fixed sonar issues part 3 * Added test coverage part 1 * Added test coverage part 2 * Added test coverage part 3 * Additional logic added for UI renderning * Added null check * Reduced code complexity for sonar * Reduced code complexity for sonar * Updated logic complexity * Additional test cases for more coverage * Updated code based on review comments * Check your answers routing (#210) * SIR-1066 pollution-substance routing from CYA * updating var name for sonarcloud * test coverage * SIR-892 pollution-appearance routing from CYA (#211) * SIR-892 pollution-appearance routing from CYA * SIR-890 change location from CYA (#212) * SIR-890 change location from CYA * removing .only from unit tests * sonarcloud * SIR-1068 CYA routing for WP source (#217) --------- Co-authored-by: Tedd <teddmason@gmail.com> * SIR-893 images-and-videos CYA routing * SIR-891 - observed date time from cya (#220) * SIR-891 - observed date time from cya * sonarcloud stuff * further test coverage for dates * SIR-889 : Story – WP – Check your answers – Watercourse & Extent (#218) * CYA - Watercourse & Extent redirection implementation * CYA - Prepopulate answers for watercourse & Extent pages * WIP - Updated test case * WIP - CYA Test cases * Added test cases for CYA watercourse & extent * SIR-894 : Story – WP – Check your answers – Dead animals (#222) * Technical implementation for SIR-894 * Removed console logs * fixing test missed from merge * SIR-895 : Story – WP – Check your answers – Other text (#225) * Technical implementation for SIR-895 * Added logs to check data on server * Added logs to check data on server * Added logs to check data on server * Removed logs --------- Co-authored-by: Tedd Mason <teddmason@gmail.com> * Reset the referer flag in case if the user restarts the WP journey before report submission (#228) --------- Co-authored-by: sujithvg <sujithvg@users.noreply.github.com>
sujithvg
added a commit
that referenced
this pull request
Dec 11, 2024
* SIR-1101 - Updating water pollution to match smell date time format (#216) * build(deps): bump webpack from 5.95.0 to 5.96.1 (#213) Bumps [webpack](https://github.com/webpack/webpack) from 5.95.0 to 5.96.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.95.0...v5.96.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump postcode-validator from 3.10.1 to 3.10.2 (#219) Bumps [postcode-validator](https://github.com/melwynfurtado/postcode-validator) from 3.10.1 to 3.10.2. - [Release notes](https://github.com/melwynfurtado/postcode-validator/releases) - [Changelog](https://github.com/melwynfurtado/postcode-validator/blob/master/release.config.js) - [Commits](melwynfurtado/postcode-validator@v3.10.1...v3.10.2) --- updated-dependencies: - dependency-name: postcode-validator dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feature/sir 1144 (#221) * SIR-1144 adding a OSGB to WGS84 point transform * sonarcloud issue * Cya epic (#234) * SIR-888: water-pollution/your-details (#205) Looks good to me :) * SIR-887 : Story – WP – Check your answers (#208) * SIR-888: water-pollution/your-details (#205) Looks good to me :) * WIP - WP CYA Page * Technical implementation for SIR-887 * Fixed all lint errors * Refactored code and added comments * Refactored code and logic update * Added unit tests for check your answers page * SIR-1102 map widget for check your answers (#207) * linting that i missed * Fixed unit test case issues * fixing unit tests * reverting date test am and AM having issues * CYA routing boilerplate * changing to form-layout otherwise post doesn''t work * Fixed sonar issues part 1 * Fixed lint issues * Fixed sonar issues part 2 * Fixed sonar issues part 3 * Added test coverage part 1 * Added test coverage part 2 * Added test coverage part 3 * Additional logic added for UI renderning * Added null check * Reduced code complexity for sonar * Reduced code complexity for sonar * Updated logic complexity * Additional test cases for more coverage * Updated code based on review comments * Check your answers routing (#210) * SIR-1066 pollution-substance routing from CYA * updating var name for sonarcloud * test coverage * SIR-892 pollution-appearance routing from CYA (#211) * SIR-892 pollution-appearance routing from CYA * SIR-890 change location from CYA (#212) * SIR-890 change location from CYA * removing .only from unit tests * sonarcloud * SIR-1068 CYA routing for WP source (#217) --------- Co-authored-by: Tedd <teddmason@gmail.com> * SIR-893 images-and-videos CYA routing * SIR-891 - observed date time from cya (#220) * SIR-891 - observed date time from cya * sonarcloud stuff * further test coverage for dates * SIR-889 : Story – WP – Check your answers – Watercourse & Extent (#218) * CYA - Watercourse & Extent redirection implementation * CYA - Prepopulate answers for watercourse & Extent pages * WIP - Updated test case * WIP - CYA Test cases * Added test cases for CYA watercourse & extent * SIR-894 : Story – WP – Check your answers – Dead animals (#222) * Technical implementation for SIR-894 * Removed console logs * fixing test missed from merge * SIR-895 : Story – WP – Check your answers – Other text (#225) * Technical implementation for SIR-895 * Added logs to check data on server * Added logs to check data on server * Added logs to check data on server * Removed logs --------- Co-authored-by: Tedd Mason <teddmason@gmail.com> * Reset the referer flag in case if the user restarts the WP journey before report submission (#228) --------- Co-authored-by: sujithvg <sujithvg@users.noreply.github.com> * Updated package version and package-lock files (#235) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tedd <teddmason@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.