Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIR-1230 : Improvement - odour - your home address #243

Merged
merged 1 commit into from
Jan 14, 2025
Merged

SIR-1230 : Improvement - odour - your home address #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server/__mock-data__/session-smell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,35 +60,35 @@ const session = JSON.parse(`{
"smell/location-address": [
{
"questionId": 1400,
"questionAsked": "Enter the address",
"questionAsked": "What is your home address?",
"questionResponse": true,
"answerId": 1401,
"otherDetails": "address 1"
},
{
"questionId": 1400,
"questionAsked": "Enter the address",
"questionAsked": "What is your home address?",
"questionResponse": true,
"answerId": 1402,
"otherDetails": "address 2"
},
{
"questionId": 1400,
"questionAsked": "Enter the address",
"questionAsked": "What is your home address?",
"questionResponse": true,
"answerId": 1403,
"otherDetails": "town"
},
{
"questionId": 1400,
"questionAsked": "Enter the address",
"questionAsked": "What is your home address?",
"questionResponse": true,
"answerId": 1404,
"otherDetails": "county"
},
{
"questionId": 1400,
"questionAsked": "Enter the address",
"questionAsked": "What is your home address?",
"questionResponse": true,
"answerId": 1405,
"otherDetails": "m11mm"
Expand Down
10 changes: 5 additions & 5 deletions server/routes/__tests__/smell/other-information.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ describe(url, () => {
expect.objectContaining({ questionId: 3200, questionAsked: 'Can you give details about where the smell is coming from?', questionResponse: true, answerId: 3204, otherDetails: 'test' }),
expect.objectContaining({ questionId: 3200, questionAsked: 'Can you give details about where the smell is coming from?', questionResponse: true, answerId: 3205, otherDetails: 'm11mm' }),
expect.objectContaining({ questionId: 3100, questionAsked: 'Is the smell affecting you at home?', questionResponse: true, answerId: 3001 }),
expect.objectContaining({ questionId: 1400, questionAsked: 'Enter the address', questionResponse: true, answerId: 1401, otherDetails: 'address 1' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'Enter the address', questionResponse: true, answerId: 1402, otherDetails: 'address 2' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'Enter the address', questionResponse: true, answerId: 1403, otherDetails: 'town' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'Enter the address', questionResponse: true, answerId: 1404, otherDetails: 'county' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'Enter the address', questionResponse: true, answerId: 1405, otherDetails: 'm11mm' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'What is your home address?', questionResponse: true, answerId: 1401, otherDetails: 'address 1' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'What is your home address?', questionResponse: true, answerId: 1402, otherDetails: 'address 2' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'What is your home address?', questionResponse: true, answerId: 1403, otherDetails: 'town' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'What is your home address?', questionResponse: true, answerId: 1404, otherDetails: 'county' }),
expect.objectContaining({ questionId: 1400, questionAsked: 'What is your home address?', questionResponse: true, answerId: 1405, otherDetails: 'm11mm' }),
expect.objectContaining({ questionId: 1900, questionAsked: 'Has this smell caused you problems before?', questionResponse: true, answerId: 1901 }),
expect.objectContaining({ questionId: 2100, questionAsked: 'Is the smell still there?', questionResponse: true, answerId: 2101 }),
expect.objectContaining({ questionId: 2200, questionAsked: 'How strong is the smell?', questionResponse: true, answerId: 2203 }),
Expand Down
2 changes: 1 addition & 1 deletion server/utils/question-sets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ const questionSets = {
SMELL_LOCATION_ADDRESS: {
questionId: 1400,
key: constants.redisKeys.SMELL_LOCATION_ADDRESS,
text: 'Enter the address',
text: 'What is your home address?',
answers: {
addressLine1: {
answerId: 1401,
Expand Down
2 changes: 1 addition & 1 deletion server/views/smell/location-address.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

{% call govukFieldset({
legend: {
text: "Enter the address",
text: "What is your home address?",
classes: "govuk-fieldset__legend--l",
isPageHeading: true
}
Expand Down
Loading