Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2205] Use no-sandbox to stop smoke tests timeouts #1165

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 16, 2025

Context

Smoke test failures: https://github.com/DFE-Digital/find-a-lost-trn/actions/runs/12772372270

Changes proposed in this pull request

Set capybara driver no-sandbox to true to avoid timeouts

Guidance to review

  • Set HOSTING_DOMAIN, SUPPORT_USERNAME, SUPPORT_PASSWORD
  • Run: bin/smoke

Link to Trello card

https://trello.com/c/WqTLwTdX

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@saliceti saliceti requested a review from a team as a code owner January 16, 2025 12:33
@saliceti saliceti force-pushed the 2205-bug-find-a-lost-trn-smoke-test-failures branch from 571b229 to 140af82 Compare January 16, 2025 12:34
@saliceti saliceti force-pushed the 2205-bug-find-a-lost-trn-smoke-test-failures branch 2 times, most recently from c7d0b2e to 7585338 Compare January 16, 2025 18:02
@saliceti saliceti changed the title [2205] Use capybara-mechanize for smoke tests [2205] Use no-sandbox to stop smoke tests timeouts Jan 16, 2025
@saliceti saliceti force-pushed the 2205-bug-find-a-lost-trn-smoke-test-failures branch from 7585338 to a7f185c Compare January 16, 2025 18:07
This is know to cause timeouts when running inside docker
@saliceti saliceti force-pushed the 2205-bug-find-a-lost-trn-smoke-test-failures branch from a7f185c to 82f1c25 Compare January 17, 2025 10:17
Copy link
Contributor

@richardpattinson richardpattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@saliceti saliceti merged commit 26c9807 into main Jan 17, 2025
12 checks passed
@saliceti saliceti deleted the 2205-bug-find-a-lost-trn-smoke-test-failures branch January 17, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants