Skip to content

Commit

Permalink
remove ttalianne.jpg image
Browse files Browse the repository at this point in the history
  • Loading branch information
martyn-w committed May 10, 2024
1 parent 17d0534 commit 0da3ed1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
Binary file removed app/webpacker/images/content/ttalianne.jpg
Binary file not shown.
5 changes: 1 addition & 4 deletions config/images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,7 @@
alt: "A physics teacher demonstrating how gravity works by juggling balls at the front of the classroom."
variants:
- "static/images/content/hero-images/physics_1383-mobile.jpg"
- "static/images/content/hero-images/physics_1383-tablet.jpg"

"static/images/content/ttalianne.jpg":
alt: "Lianne, an explore teaching adviser"
- "static/images/content/hero-images/physics_1383-tablet.jpg"

# blog
"static/images/content/blog/abigail-beeley.jpg":
Expand Down
6 changes: 3 additions & 3 deletions spec/helpers/metadata_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,17 @@
end

it "returns image/alt meta tags when given an image_path" do
tags = image_meta_tags(image_path: "static/images/content/ttalianne.jpg")
tags = image_meta_tags(image_path: "static/images/content/blog/fellowship.jpg")

expect(tags).to include(
<<~HTML.chomp,
<meta name="og:image" content="/packs-test/v1/static/images/content/ttalianne-fe8fedbf3149e8df991d.jpg">
<meta name="og:image" content="/packs-test/v1/static/images/content/blog/fellowship-14188f7670a9c10bf6d3.jpg">
HTML
)

expect(tags).to include(
<<~HTML.chomp,
<meta name="og:image:alt" content="Lianne, an explore teaching adviser">
<meta name="og:image:alt" content="Teachers Mike and Phil play on a children&#39;s climbing frame in a playground">
HTML
)
end
Expand Down
8 changes: 4 additions & 4 deletions spec/models/image_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
subject { described_class.new.build_args(path) }

context "with a valid image path" do
let(:path) { "static/images/content/ttalianne.jpg" }
let(:path) { "static/images/content/blog/fellowship.jpg" }

specify "returns the correct image path and alt text" do
expect(subject).to eql([path, { alt: "Lianne, an explore teaching adviser" }])
expect(subject).to eql([path, { alt: "Teachers Mike and Phil play on a children's climbing frame in a playground" }])
end
end

Expand All @@ -44,10 +44,10 @@
end

context "with a valid image path" do
let(:path) { "static/images/content/ttalianne.jpg" }
let(:path) { "static/images/content/blog/fellowship.jpg" }

specify "returns the correct image path and alt text" do
expect(subject).to eql("Lianne, an explore teaching adviser")
expect(subject).to eql("Teachers Mike and Phil play on a children's climbing frame in a playground")
end
end

Expand Down

0 comments on commit 0da3ed1

Please sign in to comment.