Merge pull request #3655 from DFE-Digital/create-simple-feedback-feat…

…ure-flag-for-env-migration Add simple feature flag for feedback that can be enabled / disabled per env
DFE-Digital · Nov 2, 2023 · 24d6a38 · 24d6a38
2 parents 1306092 + bce1cc2
commit 24d6a38
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 1 deletion.
diff --git a/app/components/footer_component.html.erb b/app/components/footer_component.html.erb
@@ -41,7 +41,7 @@
     <div class="site-footer-bottom">
       <div class="site-footer-bottom__links-container">
         <%= link_to("Search", search_path) %>
-        <%= link_to "Feedback", feedback_steps_path %>
+        <%= link_to "Feedback", feedback_steps_path if Rails.application.config.x.feature_flags.feedback_enabled %>
         <%= link_to "Cookies", cookies_path %>
         <%= link_to "Privacy notice", privacy_policy_path %>
         <%= link_to("Accessibility", page_path(page: :accessibility)) %>

diff --git a/app/controllers/feedback/steps_controller.rb b/app/controllers/feedback/steps_controller.rb
@@ -5,6 +5,7 @@ class StepsController < ApplicationController
     include GITWizard::Controller
     self.wizard_class = Feedback::Wizard
 
+    before_action :check_feature_flag!
     before_action :set_step_page_title, only: %i[show update]
     before_action :set_completed_page_title, only: [:completed]
 
@@ -16,6 +17,10 @@ def not_available
 
   private
 
+    def check_feature_flag!
+      redirect_to "/" unless Rails.application.config.x.feature_flags.feedback_enabled
+    end
+
     def first_step_class
       wizard_class.steps.first
     end

diff --git a/config/environments/development.rb b/config/environments/development.rb
@@ -71,6 +71,8 @@
 
   config.x.dfe_analytics = true
 
+  config.x.feature_flags.feedback_enabled = true
+
   # Allow access from Codespaces
   config.hosts << /[a-z0-9\-]+\.(preview\.app\.github|githubpreview)\.dev/
 end
diff --git a/config/environments/pagespeed.rb b/config/environments/pagespeed.rb
@@ -2,6 +2,8 @@
 require File.expand_path("production.rb", __dir__)
 
 Rails.application.configure do
+  config.x.feature_flags.feedback_enabled = true
+
   # Override any production defaults here
   config.x.git_api_endpoint = \
     "https://getintoteachingapi-test.test.teacherservices.cloud/api"

diff --git a/config/environments/preprod.rb b/config/environments/preprod.rb
@@ -18,4 +18,6 @@
   config.view_component.show_previews = true
 
   config.x.dfe_analytics = true
+
+  config.x.feature_flags.feedback_enabled = true
 end
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -141,6 +141,8 @@
 
   config.x.dfe_analytics = true
 
+  config.x.feature_flags.feedback_enabled = false
+
   # Ensure beta redirect happens before static page cache.
   config.middleware.insert_before ActionDispatch::Static, Rack::HostRedirect, {
     "beta-getintoteaching.education.gov.uk" => "getintoteaching.education.gov.uk",

diff --git a/config/environments/rolling.rb b/config/environments/rolling.rb
@@ -11,4 +11,6 @@
   config.x.display_content_errors = true
 
   config.x.dfe_analytics = true
+
+  config.x.feature_flags.feedback_enabled = true
 end
diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -55,4 +55,5 @@
   config.x.integration_credentials = { username: ENV["HTTP_USERNAME"], password: ENV["HTTP_PASSWORD"] }
   config.x.mailsac_api_key = ENV["MAILSAC_API_KEY"]
   config.x.dfe_analytics = true
+  config.x.feature_flags.feedback_enabled = true
 end