Skip to content

Commit

Permalink
update govuk frontend
Browse files Browse the repository at this point in the history
remove redundant roles from main, header, footer and nav tags
  • Loading branch information
martyn-w committed Apr 15, 2024
1 parent 0481cc9 commit d3d146a
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion app/components/footer_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<%= render Footer::CookieAcceptanceComponent.new %>

<footer class="site-footer" role="contentinfo">
<footer class="site-footer">
<div class="site-footer__wrapper limit-content-width">
<div class="site-footer-top">
<div class="site-footer-top__social">
Expand Down
2 changes: 1 addition & 1 deletion app/components/header_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</div>
</div>

<header class="limit-content-width" data-controller="navigation" role="banner" data-module="govuk-header">
<header class="limit-content-width" data-controller="navigation" data-module="govuk-header">
<%= render Header::ExtraNavigationComponent.new(search_input_id: "searchbox__input--desktop") %>
<%= render Header::LogoComponent.new %>
<div class="menu-button" id="mobile-navigation-menu-button">
Expand Down
1 change: 0 additions & 1 deletion app/helpers/application_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def body_tag(attributes = {}, &block)

def main_tag(attributes = {}, &block)
attributes[:id] = "main-content"
attributes[:role] = "main"

tag.main(**attributes, &block)
end
Expand Down
2 changes: 1 addition & 1 deletion app/views/kaminari/_paginator.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
paginator: the paginator that renders the pagination tags inside
-%>
<%= paginator.render do -%>
<nav class="pagination" aria-label="pager" role="navigation">
<nav class="pagination" aria-label="pager">
<%= prev_page_tag unless current_page.first? %>
<% each_page do |page| -%>
<% if page.display_tag? -%>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"dayjs": "^1.11.10",
"file-loader": "^6.2.0",
"flatpickr": "^4.6.13",
"govuk-frontend": "^5.2.0",
"govuk-frontend": "^5.3.0",
"is-touch-device": "^1.0.1",
"js-cookie": "^3.0.5",
"lazysizes": "^5.3.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4154,10 +4154,10 @@ gopd@^1.0.1:
dependencies:
get-intrinsic "^1.1.3"

govuk-frontend@^5.2.0:
version "5.2.0"
resolved "https://registry.yarnpkg.com/govuk-frontend/-/govuk-frontend-5.2.0.tgz#f8e0bf98b771b8ee1501fd45bbba24a091f3846d"
integrity sha512-beD3wztHpkKz6JUpPwnwop1ejb4rTFMPLCutKLCIDmUS4BPpW59ggVUfctsRqHd2Zjw9wxljdRdeIJ8AZFyyTw==
govuk-frontend@^5.3.0:
version "5.3.0"
resolved "https://registry.yarnpkg.com/govuk-frontend/-/govuk-frontend-5.3.0.tgz#f9a2b405925beada90d074e17939f9d8ddcd256e"
integrity sha512-w6yaaDU3nqhVmWJFnOuJKRIUEB/2RrTFGzoA3z5n4cTG9h292EseT/q+JJA/LYTf5IYzeTIVAUbE5fFjUxefiQ==

graceful-fs@^4.1.2, graceful-fs@^4.2.4, graceful-fs@^4.2.6, graceful-fs@^4.2.9:
version "4.2.10"
Expand Down

0 comments on commit d3d146a

Please sign in to comment.