Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events card component issue #3654

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

garethwilliamsdesign
Copy link
Contributor

Trello card

Trello 5184

Context

As a result of improving the category card design, we inadvertently affected the event listing on the About GIT events page https://getintoteaching.education.gov.uk/events/about-get-into-teaching-events. We therefore need to apply a fix for the category cards on this page.

Changes proposed in this pull request

Change the background back to white for this page only.

Guidance to review

Check that the category cards on this page are white, as before.

@github-actions github-actions bot added ruby Pull requests that update Ruby code Style labels Oct 26, 2023
@garethwilliamsdesign garethwilliamsdesign temporarily deployed to Review October 26, 2023 15:38 — with GitHub Actions Inactive
@garethwilliamsdesign garethwilliamsdesign temporarily deployed to review_aks October 26, 2023 15:38 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions github-actions bot added the Review_v2 Create AKS review app label Oct 26, 2023
@garethwilliamsdesign garethwilliamsdesign marked this pull request as ready for review October 26, 2023 15:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

97.2% 97.2% Coverage
0.2% 0.2% Duplication

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@StackedPancakez StackedPancakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@garethwilliamsdesign garethwilliamsdesign merged commit f469ad5 into master Oct 27, 2023
26 checks passed
@garethwilliamsdesign garethwilliamsdesign deleted the fix-category-card-issue branch October 27, 2023 08:44
@garethwilliamsdesign garethwilliamsdesign temporarily deployed to Review October 27, 2023 08:44 — with GitHub Actions Inactive
@garethwilliamsdesign garethwilliamsdesign temporarily deployed to review_aks October 27, 2023 08:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review_v2 Create AKS review app Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants