Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match search icon size to other icons in bonus bar #3696

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

garethwilliamsdesign
Copy link
Contributor

Trello card

Trello 5247

Context

Whilst working on the above ticket, I noticed that the search icon in the bonus bar was significantly smaller than the other icons in this component. Increasing the size of this icon to match others is likely to improve the visibility of this button.

Changes proposed in this pull request

Increase the size of the search icon to 24px x 24px, matching other icons in the bonus bar.

Guidance to review

Check that the search icon is the same size as the other icons.

Copy link

@github-actions github-actions bot added the Review_v2 Create AKS review app label Nov 10, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.2% 0.2% Duplication

@garethwilliamsdesign garethwilliamsdesign marked this pull request as ready for review November 10, 2023 11:41
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@garethwilliamsdesign garethwilliamsdesign merged commit 9db608d into master Nov 10, 2023
22 checks passed
@garethwilliamsdesign garethwilliamsdesign deleted the resize-search-icon branch November 10, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review_v2 Create AKS review app Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants