-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New page: When to apply #3705
New page: When to apply #3705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @caitlin-reidy - a few minor comments from me
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
…ply-for-teacher-training.md Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
…ply-for-teacher-training.md Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
…ply-for-teacher-training.md Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to actually post my review comments yesterday but presume you are happy with these suggestions @garethwilliamsdesign ?
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
app/views/content/how-to-apply-for-teacher-training/when-to-apply-for-teacher-training.md
Outdated
Show resolved
Hide resolved
AKS Review app deployed to https://get-into-teaching-app-review-3705.test.teacherservices.cloud |
SonarCloud Quality Gate failed. 1 Bug 96.2% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Trello card
https://trello.com/c/DzvWnWBl/5080-create-guidance-on-when-to-apply-for-teacher-training
Context
Create guidance for when users can apply for teacher training courses.
Guidance to review
2i needed from Gemma and Maxine