Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page: When to apply #3705

Merged
merged 23 commits into from
Nov 24, 2023
Merged

New page: When to apply #3705

merged 23 commits into from
Nov 24, 2023

Conversation

caitlin-reidy
Copy link
Contributor

@caitlin-reidy caitlin-reidy commented Nov 20, 2023

Trello card

https://trello.com/c/DzvWnWBl/5080-create-guidance-on-when-to-apply-for-teacher-training

Context

Create guidance for when users can apply for teacher training courses.

Guidance to review

2i needed from Gemma and Maxine

@github-actions github-actions bot added the content Content changes label Nov 20, 2023
@github-actions github-actions bot added the Review_v2 Create AKS review app label Nov 20, 2023
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @caitlin-reidy - a few minor comments from me

…ply-for-teacher-training.md

Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
…ply-for-teacher-training.md

Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
…ply-for-teacher-training.md

Co-authored-by: gemmadallmandfe <87642394+gemmadallmandfe@users.noreply.github.com>
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to actually post my review comments yesterday but presume you are happy with these suggestions @garethwilliamsdesign ?

Copy link

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.2% 0.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@caitlin-reidy caitlin-reidy merged commit 760338d into master Nov 24, 2023
20 of 21 checks passed
@caitlin-reidy caitlin-reidy deleted the When-to-apply branch November 24, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review_v2 Create AKS review app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants