Missing expanded aria menu #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
|
AKS Review app deployed to https://get-into-teaching-app-review-3717.test.teacherservices.cloud |
|
SonarCloud Quality Gate failed.
|
gemmadallmandfe
approved these changes
Nov 28, 2023
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
5243
Context
The accessibility audit showed that these expandable components did not have the correct aria attributes available. These needed to be added and values updated accordingly with user action.
Changes proposed in this pull request
Add the role, aria-expanded and aria-controls attributes to the relevant html elements, and include logic to adjust accordingly.
Guidance to review
In the review app ensure html attributes are present and changing as expected in the DOM when each of the toggle elements are clicked by the user.