Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass blocks #3779

Merged
merged 10 commits into from
Jan 15, 2024
Merged

Bypass blocks #3779

merged 10 commits into from
Jan 15, 2024

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Jan 4, 2024

Ensures that when the user clicks on "skip to main content" they arrive directly at the main content and are not presented with a back button as the first link.

Trello card

5442

Context

Following a DAC Audit, it was noted that repeated content blocks should be bypassed when clicking on "Skip to main content", to aid accessibility of the site and comply with WCAG 2.4.1

Changes proposed in this pull request

Implement required changes on the mailing list signup wizard, as a precursor for rolling out to other areas of the site.

Guidance to review

  • Please test the "Skip to main content" button now skips to the correct part of the page on the signup form
  • Please test on both webbrowser and tablet/phone
  • Verify the look and feel of the site is otherwise unchanged

now working for signup registration wizard
@github-actions github-actions bot added ruby Pull requests that update Ruby code Style labels Jan 4, 2024
@github-actions github-actions bot added the Review_v2 Create AKS review app label Jan 4, 2024
ekumachidi
ekumachidi previously approved these changes Jan 5, 2024
Copy link
Contributor

@ekumachidi ekumachidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@martyn-w
Copy link
Contributor Author

martyn-w commented Jan 5, 2024

Should be OK to merge on Monday 8/1

@gemmadallmandfe
Copy link
Contributor

gemmadallmandfe commented Jan 5, 2024

I've successfully tested the changes on the front end on desktop as a keyboard user, for the following forms:

  • mailing list
  • events
  • adviser
  • callback
  • feedback

Focus from Skip to main content went to the first form element rather than the Back link; the back link position was as expected

However, I've also tested on mobile (iPhone 11) using VoiceOver. The Skip to main content appears to still take the user to the Back link first? Let's review on Monday @martyn-w

fix linting issues
@gemmadallmandfe
Copy link
Contributor

Thanks @martyn-w - I've tested as a keyboard only user on desktop and as a iPhone 11 / iOS / Safari VoiceOver user and all looks good now - if I select Skip to main content, I am taken to the body rather than the Back link

One minor issue - if I do that, the focus area has a visible outline, in both cases - like this:

image

Copy link

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@martyn-w
Copy link
Contributor Author

This issue is discussed in https://axesslab.com/skip-links/

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (other than iOS issues which are beyond our control)

Tested successfully as keyboard user on desktop
Tested successfully on iPhone 12 and up in landscape mode

Happy for this to be merged as this is an improvement on what we have; we will return to this if there are future iOS releases that enable us to fix this for all iPhone users

@martyn-w martyn-w merged commit df30557 into master Jan 15, 2024
21 of 22 checks passed
@martyn-w martyn-w deleted the back-link-outside-main branch January 15, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review_v2 Create AKS review app Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants