Add NOSONAR comment #3805
Merged
Add NOSONAR comment #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekumachidi
previously approved these changes
Jan 16, 2024
Add explanatory comment
ekumachidi
reviewed
Jan 16, 2024
ekumachidi
previously approved these changes
Jan 16, 2024
Co-authored-by: Ekuma Chidi <7931750+ekumachidi@users.noreply.github.com>
This reverts commit 7580932.
|
Review app deployed to https://get-into-teaching-app-review-3805.test.teacherservices.cloud |
ekumachidi
approved these changes
Jan 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Fix sonarcloud issue with new event card component
Context
SonarCloud code analysis is incorrectly identifying a code snippet as invalid as it does not appear to have a wrapping
<ul>container - in the fact the element is wrapped by a<ul>generated in a parent templateChanges proposed in this pull request
Mark the
<li>element as ignored for analysis in SonarCloudGuidance to review
Verify there are no errors raised in SonarCloud