languages page #3848
Closed
languages page #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ruby
MaxineCl
reviewed
Feb 19, 2024
| <%= render(CallsToAction::Promo::PromoComponent.new) do |promo| %> | ||
| <% promo.with_left_section(classes: %w[tta-background]) %> | ||
| <% promo.with_right_section(heading: "Get free one-to-one support") do %> | ||
| <p>An adviser with years of teaching experience can help you to become a languages teacher. Chat through phone, text, or email as little or often as you need.</p> |
There was a problem hiding this comment.
@caitlin-reidy not sure if it says this in all the promo boxes as I just noticed it here. But chat through phone sounds a bit odd. Not sure if by might be better? Or if it can be reworded?
There was a problem hiding this comment.
Change to 'You can talk to them by phone, text or email'? @MaxineCl
MaxineCl
reviewed
Feb 19, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 19, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 19, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 19, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 19, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Feb 20, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Mar 5, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
MaxineCl
reviewed
Mar 5, 2024
| <%= render TextBlockWithTwoImagesComponent.new( | ||
| heading: "Empower your pupils", | ||
| colour: "pink", | ||
| image_1_path: "static/images/content/hero-images/0017.jpg", |
There was a problem hiding this comment.
@caitlin-reidy can you or Jen swap all the images for the new language teacher ones we have from the campaign
There was a problem hiding this comment.
@jenhadfield-dfe are you able to change the images please
MaxineCl
reviewed
Mar 5, 2024
app/views/content/is-teaching-right-for-me/languages/_article.html.erb
Outdated
Show resolved
Hide resolved
| <section class="col col-720"> | ||
| <p>Being a modern languages teacher is rewarding as you can open young minds to the languages and cultures around the world.</p> | ||
| <p>There are 18 modern languages you could teach with the most popular being French, German and Spanish.</p> | ||
| <p>Tax-free bursaries of £25,000 or scholarships of £27,000 are available for eligible trainee modern languages teachers.</p> |
There was a problem hiding this comment.
Suggested change
| <p>Tax-free bursaries of £25,000 or scholarships of £27,000 are available for eligible trainee modern languages teachers.</p> | |
| <p>Tax-free bursaries of £25,000 or scholarships of £27,000 are available for eligible trainee modern languages teachers.</p> |
I think this is misleading - the scholarships are only for French, German and Spanish?
|
Review app deployed to https://get-into-teaching-app-review-3848.test.teacherservices.cloud |
|
| <section class="col col-720"> | ||
| <p>Being a modern languages teacher is rewarding as you can open young minds to the languages and cultures around the world.</p> | ||
| <p>There are 18 modern languages you could teach with the most popular being French, German and Spanish.</p> | ||
| <p>Tax-free bursaries of £25,000 are available for eligible trainee Spanish, German and French teachers. Scholarships of £27,000 are available for eligible trainee modern languages teachers.</p> |
There was a problem hiding this comment.
@caitlin-reidy This is now the wrong way round - bursaries are for all languages teachers, but scholarships are only for French, German and Spanish (as per later down on the page)
|
Closing this PR for now - to be re-opened when we are ready to continue with this cc @MaxineCl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/tCUU1ovr/5344-develop-a-languages-page
Context
Changes proposed in this pull request
Guidance to review