Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Student-loans #3885

Merged
merged 46 commits into from
Mar 12, 2024
Merged

Student-loans #3885

merged 46 commits into from
Mar 12, 2024

Conversation

MaxineCl
Copy link
Contributor

@MaxineCl MaxineCl commented Mar 4, 2024 •
edited
Loading

Trello card

https://trello.com/c/oZbRmLca/5649-amend-tuition-fees-and-maintenance-loans-page-based-on-user-research

Context

We need to make it clearer on this page https://getintoteaching.education.gov.uk/funding-and-support/tuition-fee-and-maintenance-loans that there are 2 different types of loans available and that amounts differ depending on

  • if courses are full-time or part-time
  • where candidates live
  • the calculator is an estimate

Changes proposed in this pull request

  • Split the content into 2 different sections for tuition fee loans and maintenance loans
  • Add in content to cover the bullets above
  • Change page title to match tab title

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Mar 4, 2024
@github-actions github-actions bot added the Review label Mar 4, 2024
@MaxineCl MaxineCl requested a review from caitlin-reidy March 4, 2024 19:31
@MaxineCl MaxineCl requested a review from gemmadallmandfe March 5, 2024 16:23
@MaxineCl MaxineCl added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Mar 6, 2024
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-3885.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
7 New issues
10 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gemmadallmandfe
gemmadallmandfe approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MaxineCl MaxineCl merged commit 243cf35 into master Mar 12, 2024
26 checks passed
@MaxineCl MaxineCl deleted the student-loans branch March 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caitlin-reidy caitlin-reidy caitlin-reidy left review comments

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxineCl @gemmadallmandfe @caitlin-reidy