Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why train to teach in England video transcript deleted and redirect c… #3930

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

laurahermionetennant92
Copy link
Contributor

@laurahermionetennant92 laurahermionetennant92 commented Apr 3, 2024

…reated

Why train to teach in England video transcript deleted and redirect created

Trello card

https://trello.com/c/hMEZyj9V/5789-remove-why-teach-in-england-video-transcript-page

Context

Changes proposed in this pull request

Guidance to review

…reated

Why train to teach in England video transcript deleted and redirect created
@github-actions github-actions bot added content Content changes Config labels Apr 3, 2024
@laurahermionetennant92
Copy link
Contributor Author

Hi @martyn-w :)
Not sure why this is failing to deploy, could you take a look when you get a sec?
Thank you

@martyn-w
Copy link
Contributor

martyn-w commented Apr 3, 2024

Hi @laurahermionetennant92 it looks to be failing because of a routing error. I notice you have added a new redirect; try adding a space after the colon : and see if that fixes it?
i.e. change line 40 of config/redirects.yml to:

"/non-uk-teachers/why-train-to-teach-transcript": "/non-uk-teachers/train-to-teach-in-england-as-an-international-student"

Add space to redirect
Copy link

github-actions bot commented Apr 3, 2024

@github-actions github-actions bot added the Review label Apr 3, 2024
Copy link

sonarqubecloud bot commented Apr 3, 2024

@laurahermionetennant92
Copy link
Contributor Author

That worked @martyn-w !
@MaxineCl Please review :)

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@laurahermionetennant92 laurahermionetennant92 marked this pull request as ready for review April 8, 2024 11:37
@laurahermionetennant92 laurahermionetennant92 merged commit 146626b into master Apr 8, 2024
26 checks passed
@laurahermionetennant92 laurahermionetennant92 deleted the Delete-video-transcript branch April 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants