Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deep link to engineers teach physics courses on Find #3934

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

MaxineCl
Copy link
Contributor

@MaxineCl MaxineCl commented Apr 5, 2024

Trello card

https://trello.com/c/QxlvDOy6/2187-update-link-to-engineers-teach-physics-courses-on-subject-page

Context

We currently have a link on the Engineers teach physics page https://getintoteaching.education.gov.uk/subjects/engineers-teach-physics that goes to the Find start page. We agreed that we should try deep linking directly to the Engineers teach physics courses as there are less than 20 in total.

Changes proposed in this pull request

Update the link on the Engineers teach physics page to go straight to the ETP courses search results

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Apr 5, 2024
@MaxineCl MaxineCl requested a review from gemmadallmandfe April 5, 2024 13:55
@MaxineCl MaxineCl added Review content Content changes and removed content Content changes ruby Pull requests that update Ruby code labels Apr 5, 2024
@gemmadallmandfe
Copy link
Contributor

Looks good to me but just need to check with Find team

@@ -63,7 +63,7 @@
<p>You'll also be invited to an annual community day and have the opportunity to network with existing physics teachers.
</p>

<p>You can <a href="https://www.find-postgraduate-teacher-training.service.gov.uk/">search for physics teacher training courses</a> and then filter by 'Engineers teach physics'.
<p><a href="https://www.find-postgraduate-teacher-training.service.gov.uk/results?engineers_teach_physics=true&degree_required=two_two&applications_open=false&l=2&subjects%5B%5D=F3">Find engineers teach physics teacher training courses</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only suggestion, and happy to be overruled on it is to add the filter for 'courses that are open', which would be this URL:
https://www.find-postgraduate-teacher-training.service.gov.uk/results?engineers_teach_physics=true&study_type%5B%5D=full_time&study_type%5B%5D=part_time&qualification%5B%5D=qts&qualification%5B%5D=pgce_with_qts&qualification%5B%5D=pgce+pgde&degree_required=two_two&applications_open=false&applications_open=true&l=2&subjects%5B%5D=F3

It uses this filter:
image

This gives 16 results instead of the current 17. Is our aim to give users access to the full suite of courses, or to show them those that they can apply to at this specific moment? cc @gemmadallmandfe

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we should only link to open courses, particularly as it is not at all clear in the search results which ones are open!

cc @MaxineCl

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 12, 2024
Copy link

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - although the link could be simplified, this is the structure used by Find currently so makes sense to replicate it

This can be deployed first thing on Monday

@MaxineCl MaxineCl merged commit 89c51bf into master Apr 15, 2024
26 checks passed
@MaxineCl MaxineCl deleted the update-engineers-teach-physics-Find-link branch April 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants