Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of mailing list title #3973

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

martyn-w
Copy link
Contributor

Trello card

Amend Sign up to emails icon CSS to fix text wrapping on home page

Context

The mailing list title wraps on to a new line past the icon

Changes proposed in this pull request

This uses a flex-box layout to force the wrapping to be more consistent

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code Style labels May 13, 2024
@martyn-w
Copy link
Contributor Author

iPhone 13 (portrait mode)

Screenshot 2024-05-13 at 13 10 04

iPhone 13 (landscape mode)

Screenshot 2024-05-13 at 13 10 34

320px screen width

Screenshot 2024-05-13 at 13 10 54

Edge browser (wide)

Screenshot 2024-05-13 at 13 12 13

Edge browser (narrow)

Screenshot 2024-05-13 at 13 12 35

Copy link

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - happy for this to be merged if @jenhadfield-dfe is happy!

@martyn-w martyn-w merged commit fdfc7fe into master May 13, 2024
26 checks passed
@martyn-w martyn-w deleted the mailing-list-title-wrapping branch May 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants